Skip to content

fix(ci): fix auto-approve to check claude[bot] comment #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JasonXuDeveloper merged 1 commit into from
Jan 26, 2026
Merged

fix(ci): fix auto-approve to check claude[bot] comment #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .github/workflows/auto-approve.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,16 @@ jobs:
HEAD_SHA=$(gh api repos/${{ github.repository }}/pulls/$PR_NUMBER --jq '.head.sha')
echo "Head SHA: $HEAD_SHA"

# Check Claude review status and output
CLAUDE_CHECK=$(gh api repos/${{ github.repository }}/commits/$HEAD_SHA/check-runs --jq '.check_runs[] | select(.name == "claude-review")')
CLAUDE_STATUS=$(echo "$CLAUDE_CHECK" | jq -r '.conclusion' | head -1)
CLAUDE_OUTPUT=$(echo "$CLAUDE_CHECK" | jq -r '.output.summary // .output.text // ""' | head -1)
echo "Claude review status: $CLAUDE_STATUS"
echo "Claude review output: $CLAUDE_OUTPUT"

# Check if Claude found no issues (exact message check)
# Check Claude review - look for "No issues found" comment from claude[bot]
# Claude posts a PR comment with this message when review passes
CLAUDE_COMMENTS=$(gh api "repos/${{ github.repository }}/issues/$PR_NUMBER/comments" --jq '[.[] | select(.user.login == "claude[bot]") | .body] | join("\n")')

CLAUDE_APPROVED="false"
if [ "$CLAUDE_STATUS" == "success" ] && echo "$CLAUDE_OUTPUT" | grep -q "No issues found. Checked for bugs and CLAUDE.md compliance"; then
if echo "$CLAUDE_COMMENTS" | grep -q "No issues found. Checked for bugs and CLAUDE.md compliance"; then
echo "Claude review: No issues found"
CLAUDE_APPROVED="true"
else
echo "Claude review: Issues found or not yet complete"
fi
echo "Claude approved: $CLAUDE_APPROVED"

Expand Down
10 changes: 10 additions & 0 deletions .scorecard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,13 @@ annotations:
- token-permissions
reasons:
- reason: not-applicable # Write permissions required for test reporting and release automation

# Branch protection: Using GitHub Rulesets with auto-approve bot
# - Rulesets require 1 approver (provided by auto-approve bot)
# - Code owner review is required
# - last_push_approval disabled to allow auto-approve bot to work
# - bypass_actors: [] prevents admin bypass
- checks:
- branch-protection
reasons:
- reason: not-applicable # Using Rulesets with auto-approve bot requiring last_push_approval disabled