Skip to content

Conversation

@JasonXuDeveloper
Copy link
Owner

Summary

Add annotation explaining why Branch-Protection score is not maximal:

  • Using GitHub Rulesets instead of classic branch protection
  • Rulesets require 1 approver and code owner review
  • last_push_approval disabled to allow auto-approve bot to work
  • Admin bypass prevented via bypass_actors: [] in rulesets

Test plan

  • Scorecard scan acknowledges the annotation

🤖 Generated with Claude Code

Using GitHub Rulesets instead of classic branch protection:
- Rulesets require 1 approver and code owner review
- last_push_approval disabled to allow auto-approve bot
- bypass_actors: [] prevents admin bypass

Signed-off-by: JasonXuDeveloper - 傑 <[email protected]>
@github-actions github-actions bot added the ci label Jan 26, 2026
Claude Code Action posts a comment with 'No issues found. Checked for
bugs and CLAUDE.md compliance.' when review passes. Check for this
comment instead of check run output fields which are not set.

Signed-off-by: JasonXuDeveloper - 傑 <[email protected]>
@JasonXuDeveloper JasonXuDeveloper force-pushed the fix/branch-protection-annotation branch from e0e7257 to 312e5c9 Compare January 26, 2026 09:03
@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Unity Test Results

EditMode: All tests passed
PlayMode: All tests passed

Unity Version: 2022.3.55f1
Project Path: UnityProject

✅ All tests passed! The PR is ready for review.

View workflow run

Click here to view the full workflow run

@claude
Copy link

claude bot commented Jan 26, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@JasonXuDeveloper
Copy link
Owner Author

Closing to create a cleaner PR with just the auto-approve fix.

@claude
Copy link

claude bot commented Jan 26, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@JasonXuDeveloper JasonXuDeveloper deleted the fix/branch-protection-annotation branch January 28, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants