Skip to content

Cli updates#357

Merged
naik-aakash merged 32 commits intoJaGeo:mainfrom
naik-aakash:cli_updates
Jan 13, 2025
Merged

Cli updates#357
naik-aakash merged 32 commits intoJaGeo:mainfrom
naik-aakash:cli_updates

Conversation

@naik-aakash
Copy link
Collaborator

@naik-aakash naik-aakash commented Jan 1, 2025

Closes #344 and #328

Note: Failing tests in CI are due to the pymatgen depreciation of some methods and have nothing to do with LobsterPy / pymatgen LOBSTER parsers/changes in this PR.

Todo

  • coloured icoxx distance plots via CLI
  • add option to get BWDF plots
  • Update cli docs and tutorials to showcase BWDF / ICOXX distance plotting
  • Option to save raw plot data of relevant (I)COXX as jsons

@naik-aakash naik-aakash self-assigned this Jan 1, 2025
@naik-aakash naik-aakash added the enhancement New feature or request label Jan 1, 2025
@JaGeo
Copy link
Owner

JaGeo commented Jan 3, 2025

Can we fix the LobsterPy tests here first and then add new functionalities? @naik-aakash

@naik-aakash
Copy link
Collaborator Author

naik-aakash commented Jan 3, 2025

Hi @JaGeo , as I have written in the note, it has nothing to do with LobsterPy tests. We have to wait for new release of pymatgen where deprecated method is removed causing failures due to monty warnings

See here : materialsproject/pymatgen#4243

@JaGeo
Copy link
Owner

JaGeo commented Jan 3, 2025

@naik-aakash thank you 😅. I also wrote something in the pymatgen PR

@naik-aakash naik-aakash changed the title [WIP] Cli updates Cli updates Jan 5, 2025
@naik-aakash naik-aakash enabled auto-merge January 5, 2025 15:19
@naik-aakash naik-aakash requested review from JaGeo and removed request for JaGeo January 5, 2025 15:19
@naik-aakash naik-aakash requested a review from JaGeo January 6, 2025 08:10
@naik-aakash
Copy link
Collaborator Author

Hi @kaueltzen, I have now addressed the review comments. Let me know if anything else needs to be addressed.

Copy link
Contributor

@kaueltzen kaueltzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just some small suggestions

@kaueltzen
Copy link
Contributor

@JaGeo am done, this is ready to be merged imo (: 👍

@naik-aakash naik-aakash requested a review from JaGeo January 13, 2025 17:05
return plt


class BWDFPlotter:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be something for pymatgen in the future once BWDF in Lobster are more established

@naik-aakash naik-aakash merged commit ab90778 into JaGeo:main Jan 13, 2025
22 checks passed
@JaGeo
Copy link
Owner

JaGeo commented Jan 13, 2025

@naik-aakash and @kaueltzen thank you both!

Let me know if a new version is required!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to plot BWDF and coloured icoxx distance plots via CLI

3 participants