Conversation
|
Can we fix the LobsterPy tests here first and then add new functionalities? @naik-aakash |
|
Hi @JaGeo , as I have written in the note, it has nothing to do with LobsterPy tests. We have to wait for new release of pymatgen where deprecated method is removed causing failures due to monty warnings See here : materialsproject/pymatgen#4243 |
|
@naik-aakash thank you 😅. I also wrote something in the pymatgen PR |
|
Hi @kaueltzen, I have now addressed the review comments. Let me know if anything else needs to be addressed. |
kaueltzen
left a comment
There was a problem hiding this comment.
Looks good! just some small suggestions
|
@JaGeo am done, this is ready to be merged imo (: 👍 |
| return plt | ||
|
|
||
|
|
||
| class BWDFPlotter: |
There was a problem hiding this comment.
Could be something for pymatgen in the future once BWDF in Lobster are more established
|
@naik-aakash and @kaueltzen thank you both! Let me know if a new version is required! |
Closes #344 and #328
Note: Failing tests in CI are due to the pymatgen depreciation of some methods and have nothing to do with
LobsterPy/ pymatgenLOBSTERparsers/changes in this PR.Todo