Skip to content

Active Dev Branch #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kdorheim wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Active Dev Branch #794

kdorheim wants to merge 6 commits into from

Conversation

@kdorheim
Copy link
Contributor

@kdorheim kdorheim commented Oct 27, 2025 •
edited
Loading

This is a place holder PR for post V3.5.0 development. Eventually this branch will be merged into main and associated with the next Hector release.

This PR documentation will need to be updated to reflect the merged PRs.

PRs Dev Type Old-New Test Update? Description
--- minor no documentation changes only
#798 patch no bug fix in the csv output stream visitor to close #795 related to rh_ch4
#799 patch no bug fix in csv output stream, use consistent precision level

@github-actions

This comment was marked as outdated.

Sign in to view
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.41%. Comparing base (662e6ca) to head (7c7a0ec).

Files with missing lines Patch % Lines
src/csv_outputstream_visitor.cpp 0.00% 18 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
+ Coverage   80.39%   80.41%   +0.01%     
==========================================
  Files          61       61              
  Lines        6025     6024       -1     
==========================================
  Hits         4844     4844              
+ Misses       1181     1180       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

📊 Report Generated 🤖

Here is the latest automated report:

Leeyabot report!

2025-12-12

Hello, this is Leeyabot! I look for differences between the this “dev”
version of Hector and make some standard diagnostic plots. I
specifically compare this version of Hector with

  • old-new test data - 3.5.0 (commit e98dc2d)
  • previous release data - 3.5.0 (commit )

Previous Dev Version Comparison

The old-new test data is used in the R testthat unit tests to verify
that recent model development has not introduced changes to Hector’s
output. Here, we generate standard diagnostic plots to identify any
changes in model behavior.

This summary table indicates the $R^2$, root mean squared error (RMSE),
and normalized RMSE (NRMSE) for each variable and scenario. An $R^2$ of
1 and NRMSE of 0 indicate that the Hector results are identical to the
previous developmental version of Hector.

scenario variable R.squared RMSE NRMSE
ssp245 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
ssp245 global_tas (degC) 1e+00 0e+00 0e+00
ssp245 RF_CO2 (W/m2) 1e+00 0e+00 0e+00
ssp245 RF_tot (W/m2) 1e+00 0e+00 0e+00 
## The current pull request's outputs do not differ from the old-new data of Hector 3.5.0, e98dc2d

Release Version Comparison

In the remainder of the document we compare this version of Hector, the
dev version with the minted results from Hector 3.5.0 the most
recent major release. There are two different sets of experiments to be
considered here - idealized and multiforcing scenarios. Each summary
table will contain results from both types of experiments while the
diagnostic plots will consider them separately.

Idealized Experiments

scenario variable R.squared RMSE NRMSE
1pctCO2 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
abruptx4CO2 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
1pctCO2 global_tas (degC) 1e+00 0e+00 0e+00
abruptx4CO2 global_tas (degC) 1e+00 0e+00 0e+00
1pctCO2 RF_tot (W/m2) 1e+00 0e+00 0e+00
abruptx4CO2 RF_tot (W/m2) 1e+00 0e+00 0e+00 
## The current pull request's idealized outputs do not differ from the Hector release 3.5.0,

Multiforcing Experiments

scenario variable R.squared RMSE NRMSE
ssp119 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
ssp245 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
ssp585 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
ssp119 global_tas (degC) 1e+00 0e+00 0e+00
ssp245 global_tas (degC) 1e+00 0e+00 0e+00
ssp585 global_tas (degC) 1e+00 0e+00 0e+00
ssp119 RF_tot (W/m2) 1e+00 0e+00 0e+00
ssp245 RF_tot (W/m2) 1e+00 0e+00 0e+00
ssp585 RF_tot (W/m2) 1e+00 0e+00 0e+00 
## The current pull request's multiforcing outputs do not differ from the Hector release 3.5.0,

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

📊 Report Generated 🤖

Here is the latest automated report:

Leeyabot report!

2026-01-16

Hello, this is Leeyabot! I look for differences between the this “dev”
version of Hector and make some standard diagnostic plots. I
specifically compare this version of Hector with

  • old-new test data - 3.5.0 (commit e98dc2d)
  • previous release data - 3.5.0 (commit )

Previous Dev Version Comparison

The old-new test data is used in the R testthat unit tests to verify
that recent model development has not introduced changes to Hector’s
output. Here, we generate standard diagnostic plots to identify any
changes in model behavior.

This summary table indicates the $R^2$, root mean squared error (RMSE),
and normalized RMSE (NRMSE) for each variable and scenario. An $R^2$ of
1 and NRMSE of 0 indicate that the Hector results are identical to the
previous developmental version of Hector.

scenario variable R.squared RMSE NRMSE
ssp245 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
ssp245 global_tas (degC) 1e+00 0e+00 0e+00
ssp245 RF_CO2 (W/m2) 1e+00 0e+00 0e+00
ssp245 RF_tot (W/m2) 1e+00 0e+00 0e+00 
## The current pull request's outputs do not differ from the old-new data of Hector 3.5.0, e98dc2d

Release Version Comparison

In the remainder of the document we compare this version of Hector, the
dev version with the minted results from Hector 3.5.0 the most
recent major release. There are two different sets of experiments to be
considered here - idealized and multiforcing scenarios. Each summary
table will contain results from both types of experiments while the
diagnostic plots will consider them separately.

Idealized Experiments

scenario variable R.squared RMSE NRMSE
1pctCO2 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
abruptx4CO2 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
1pctCO2 global_tas (degC) 1e+00 0e+00 0e+00
abruptx4CO2 global_tas (degC) 1e+00 0e+00 0e+00
1pctCO2 RF_tot (W/m2) 1e+00 0e+00 0e+00
abruptx4CO2 RF_tot (W/m2) 1e+00 0e+00 0e+00 
## The current pull request's idealized outputs do not differ from the Hector release 3.5.0,

Multiforcing Experiments

scenario variable R.squared RMSE NRMSE
ssp119 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
ssp245 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
ssp585 CO2_concentration (ppmv CO2) 1e+00 0e+00 0e+00
ssp119 global_tas (degC) 1e+00 0e+00 0e+00
ssp245 global_tas (degC) 1e+00 0e+00 0e+00
ssp585 global_tas (degC) 1e+00 0e+00 0e+00
ssp119 RF_tot (W/m2) 1e+00 0e+00 0e+00
ssp245 RF_tot (W/m2) 1e+00 0e+00 0e+00
ssp585 RF_tot (W/m2) 1e+00 0e+00 0e+00 
## The current pull request's multiforcing outputs do not differ from the Hector release 3.5.0,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rh_ch4 bug(s)

3 participants

@kdorheim @codecov-commenter