Skip to content

🎨 Palette: Make mobile theme toggle accessible#50

Open
ItsHarta wants to merge 1 commit intomainfrom
feat-ux-mobile-theme-toggle-402579579082886906
Open

🎨 Palette: Make mobile theme toggle accessible#50
ItsHarta wants to merge 1 commit intomainfrom
feat-ux-mobile-theme-toggle-402579579082886906

Conversation

@ItsHarta
Copy link
Copy Markdown
Owner

💡 What: Replaced the mobile theme toggle <Icon> with an accessible semantic <button> in AppLayout.astro.
🎯 Why: To allow keyboard navigation for screen readers and keyboard users (focusability) while introducing ARIA properties to communicate the state.
📸 Before/After: The icon design matches the previous design pixel-for-pixel by keeping structural layout identical but wrapping the <Icon> element inside a flex container <button>.
Accessibility: Added aria-label, native title tooltip, aria-expanded true/false toggling logic to JS, and focus-visible keyboard styling.
🌗 Dark mode: Both light and dark variants retain correct styling, adjusting icon states depending on visibility.


PR created automatically by Jules for task 402579579082886906 started by @ItsHarta

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying itsharta-github-io with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76802b5
Status: ✅  Deploy successful!
Preview URL: https://9167d6d0.itsharta-github-io.pages.dev
Branch Preview URL: https://feat-ux-mobile-theme-toggle.itsharta-github-io.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant