Skip to content

Lint codebase, add lint to CI checks, fix tests #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
joecorall wants to merge 10 commits into
base: 2.x
Choose a base branch
from
Draft

Lint codebase, add lint to CI checks, fix tests #1096

joecorall wants to merge 10 commits into from

Conversation

@joecorall
Copy link
Member

@joecorall joecorall commented Jan 28, 2026 •
edited
Loading

GitHub Issue: #1095

Continue fixing CI errors (work started in #1094). This PR lints our codebase using phpcbf // phpcs. Then enables lint checking in our CI checks to ensure code is linted before being accepted. Also fixed Drupal 11.x test failures

  • Ran phpcbf to automatically lint this codebase 1e812f9
phpcbf --standard=Drupal,DrupalPractice --extensions=module,php' .
  • Manually fixed the remaining lint issues reported by phpcs e2f43d8
phpcs --standard=Drupal,DrupalPractice --extensions=module,php' .
  • Enabled lint checks in our CI fdf78af
  • Fixed Drupal 11.2

I suspect some of the Drupal 11.3 tests will get fixed by #1093

@joecorall joecorall changed the title Fix 11 tests Lint codebase, add lint to CI checks, fix 11 tests Jan 28, 2026
@joecorall joecorall force-pushed the fix-11-tests branch 2 times, most recently from 0deec06 to c6885fd Compare January 28, 2026 21:48
@joecorall joecorall changed the title Lint codebase, add lint to CI checks, fix 11 tests Lint codebase, add lint to CI checks, fix d11 tests Jan 28, 2026
@joecorall joecorall changed the title Lint codebase, add lint to CI checks, fix d11 tests Lint codebase, add lint to CI checks, fix d11.2 tests Jan 28, 2026
@joecorall joecorall marked this pull request as ready for review January 28, 2026 22:27
joecorall
joecorall commented Jan 28, 2026
View reviewed changes
@joecorall joecorall marked this pull request as draft January 28, 2026 23:19
@joecorall joecorall force-pushed the fix-11-tests branch 2 times, most recently from a7cbd88 to f7bfd77 Compare January 29, 2026 15:08
@joecorall joecorall changed the title Lint codebase, add lint to CI checks, fix d11.2 tests Lint codebase, add lint to CI checks, fix tests Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joecorall