Fix: trim xml strings before parsing them #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems and libraries add leading and/or trailing whitespaces when writing text into XML elements. For instance, the specific system I am working with now outputs XML in this format:
This is problematic since the API will try to parse every element with the spaces included. So for the
ratefactor, it will callatol(" 1 "), which will not parse properly. Another case is string comparison,alignmentcallsstrcmp("Right", " Right "), which returns false.I propose introducing a
TrimStringstatic function to theTranslatorclass. This function accepts aconst char*string and a pointer to asize_t. It will return a new pointer to the beginning of the string after any whitespaces and set thesize_t*to the actual length. This effectively trims the string in place.We can then use this new pointer to call
atol()andatof(), which will parse numbers properly despite any trailing spaces. For the case of comparing string, we can callstrncmp()instead, which will accept our length value and compare just those characters ignoring trailing spaces.I have tested these changes in my setup and it now parses the metadata file without an issue.