fix: remove dead flat serialization code#7632
Open
Robertmwatua wants to merge 1 commit intoIntersectMBO:masterfrom
Open
fix: remove dead flat serialization code#7632Robertmwatua wants to merge 1 commit intoIntersectMBO:masterfrom
Robertmwatua wants to merge 1 commit intoIntersectMBO:masterfrom
Conversation
- Remove unused DEC_BOOLG conditional compilation block - Remove commented SIZ_NUM implementation - Clean up commented debug flags - Keep only active decoding strategies Closes IntersectMBO#7542
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove dead flat serialization code
Description
This PR removes dead/buggy flat serialization code that was causing maintenance overhead. The removed code was protected by conditional compilation flags that were never enabled.
Changes
DEC_BOOLGconditional block (flag never defined)SIZ_NUMimplementation (unused)DEC_CONS,DEC_CONS48,DEC_BOOLC,DEC_BOOLWhy
Dead code increases maintenance burden and can hide bugs. Removing it makes the codebase cleaner.
Testing
Related Issue
Closes #7542