feat: native builtin data vs th builtin data benchmark#7562
Closed
colll78 wants to merge 3 commits intoIntersectMBO:masterfrom
Closed
feat: native builtin data vs th builtin data benchmark#7562colll78 wants to merge 3 commits intoIntersectMBO:masterfrom
colll78 wants to merge 3 commits intoIntersectMBO:masterfrom
Conversation
Unisay
reviewed
Feb 9, 2026
| (\_ -> True) | ||
| BI.unitval | ||
| ) | ||
| BI.unitval |
Contributor
There was a problem hiding this comment.
I did an experiment and results demonstate that multiway-if compiled by the plugin is actually better than hand-rolled lazy ifthenelse pattern you employ here:
#7578
Contributor
Author
There was a problem hiding this comment.
Good point, I guess similar could be achieved with ifThenElseLazy predicate ~a ~b = BI.ifThenElse predicate a b right? And if the branches don't contain an error and the terms are small (ie. for && which has only True and False as branches, then we would want to use BI.ifThenElse because multiway if isn't smart enough to know whether it can be safely optimized to strict (and whether it should based on the terms in the branches).
I'll update the implementation to use multiway if, I'm sure it could be further optimized, but I just did a rough translated to BuiltinData and didn't put much effort into optimization and it is already optimized to around 35% of the budget of the TH Data version.
Unisay
added a commit
that referenced
this pull request
Feb 10, 2026
…udget Compare 4 patterns for chaining boolean conditions in Plutus Tx: 1. Standard && (lazy, delay/force) 2. builtinAnd (lambda/unit, Philip DiSarro's pattern from PR #7562) 3. Multi-way if (negated guards) 4. Direct BI.ifThenElse chain (manual lambda/unit) Each pattern tested with 3 scenarios: AllTrue, EarlyFail, LateFail.
Unisay
added a commit
that referenced
this pull request
Feb 10, 2026
Extract patterns 2 and 4 into Budget.BuiltinAndLib with the exact GHC flags used in PR #7562's ValidatorOptimized.hs: - All -fno-* optimisation flags - conservative-optimisation plugin option - INLINE pragmas (not INLINEABLE) Results unchanged: builtinAnd still doesn't short-circuit (839,970 CPU in all scenarios) because Bool arguments are evaluated eagerly before the function body runs, regardless of INLINE/flags.
Unisay
added a commit
that referenced
this pull request
Feb 11, 2026
… experiment Add two more patterns to the && vs builtinAnd comparison: Pattern 5 (andBuiltinAndIfError): Philip's exact claimed usage - if (builtinAnd a $ builtinAnd b c) then ok else error Result: 919,970 CPU, no short-circuiting (all conditions evaluated) Pattern 6 (andBuiltinIfNest): Nested builtinIf with conditions in lambda bodies (Philip's actual validator pattern from PR #7562) Result: 727,970 CPU AllTrue, with proper short-circuiting
Unisay
added a commit
that referenced
this pull request
Mar 4, 2026
Introduce a ScriptContext builder module in plutus-ledger-api testlib that provides composable combinators for constructing ScriptContext values in tests. This replaces hand-crafted script contexts with a declarative builder pattern using lenses. Key changes: - Add PlutusLedgerApi.Test.ScriptContextBuilder.Builder with combinators for minting, spending, certifying, rewarding, and proposing contexts - Add PlutusLedgerApi.Test.ScriptContextBuilder.Lenses with TH-generated lenses for all V3 ledger types - Refactor LinearVesting benchmark tests to use the new builder - Fix AsData destructSum-manual test to use manual IsData instances instead of asData, regenerating golden files Based on work from PR #7562. Co-authored-by: Philip DiSarro <philip-disarro@users.noreply.github.com>
Unisay
added a commit
that referenced
this pull request
Mar 5, 2026
Introduce a ScriptContext builder module in plutus-ledger-api testlib that provides composable combinators for constructing ScriptContext values in tests. This replaces hand-crafted script contexts with a declarative builder pattern using lenses. Key changes: - Add PlutusLedgerApi.Test.ScriptContextBuilder.Builder with combinators for minting, spending, certifying, rewarding, and proposing contexts - Add PlutusLedgerApi.Test.ScriptContextBuilder.Lenses with TH-generated lenses for all V3 ledger types - Refactor LinearVesting benchmark tests to use the new builder - Fix AsData destructSum-manual test to use manual IsData instances instead of asData, regenerating golden files Based on work from PR #7562. Co-authored-by: Philip DiSarro <philip-disarro@users.noreply.github.com>
Unisay
added a commit
that referenced
this pull request
Mar 10, 2026
…7643) * Add ScriptContext Builder testlib and refactor LinearVesting tests Introduce a ScriptContext builder module in plutus-ledger-api testlib that provides composable combinators for constructing ScriptContext values in tests. This replaces hand-crafted script contexts with a declarative builder pattern using lenses. Key changes: - Add PlutusLedgerApi.Test.ScriptContextBuilder.Builder with combinators for minting, spending, certifying, rewarding, and proposing contexts - Add PlutusLedgerApi.Test.ScriptContextBuilder.Lenses with TH-generated lenses for all V3 ledger types - Refactor LinearVesting benchmark tests to use the new builder - Fix AsData destructSum-manual test to use manual IsData instances instead of asData, regenerating golden files Based on work from PR #7562. Co-authored-by: Philip DiSarro <philip-disarro@users.noreply.github.com> * Replace redundant helpers with existing API functions - Replace local isPubKeyAddress/isScriptAddress with toPubKeyHash/toScriptHash from PlutusLedgerApi.V1.Address - Replace negateValue with PlutusTx.negate (Value has AdditiveGroup) - Export and relocate currencySymbolFromHex and singleCurrencySymbol to a dedicated Helpers section at the bottom of Builder.hs Co-authored-by: Philip DiSarro <philip-disarro@users.noreply.github.com> * Regenerate golden files for LinearVesting and CallTrace tests --------- Co-authored-by: Philip DiSarro <philip-disarro@users.noreply.github.com>
Contributor
|
Optimized linear vesting validator #7658 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a benchmark using very crude and barely optimized native builtin data functions to compare against the existing Vesting contract implemented with TH AsData stuff.
Added script context builder for constructing realistic script contexts which obey ledger invariants.