fix(builder): pass network to makeTxBuilder for correct slot config#204
Merged
solidsnakedev merged 4 commits intomainfrom Mar 14, 2026
Merged
fix(builder): pass network to makeTxBuilder for correct slot config#204solidsnakedev merged 4 commits intomainfrom
solidsnakedev merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes slot configuration resolution in the SDK’s transaction builder by ensuring the client passes the selected network into makeTxBuilder(), and adds a regression test to verify validity interval slot conversion differs across networks.
Changes:
- Pass
networkintomakeTxBuilder()from both read-only and signing clients so slot presets resolve correctly. - Add a new
TxBuildertest suite validating network-specific slot conversion for validity intervals. - Add a changeset documenting the patch release.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/evolution/test/TxBuilder.SlotConfig.test.ts | Adds regression tests to ensure validity interval times convert to slots using the correct network’s slot config. |
| packages/evolution/src/sdk/client/ClientImpl.ts | Introduces toBuilderNetwork() and wires network through to makeTxBuilder() in client constructors. |
| .changeset/fix-slot-config-network.md | Declares a patch release describing the slot-config fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+118
to
+131
| const toBuilderNetwork = (networkId: NetworkId): Network.Network => { | ||
| if (typeof networkId === "number") { | ||
| return networkId === 1 ? "Mainnet" : "Preview" | ||
| } | ||
| switch (networkId) { | ||
| case "mainnet": | ||
| return "Mainnet" | ||
| case "preprod": | ||
| return "Preprod" | ||
| case "preview": | ||
| return "Preview" | ||
| default: | ||
| return "Mainnet" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.