cardano: Disable p2p for preview and preprod networks #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disassembler
requested changes
Sep 15, 2022
Collaborator
disassembler
left a comment
disassembler
left a comment
There was a problem hiding this comment.
This PR would be disastrous. We can't change preview/preprod to not use p2p. The entire network depends on that being enabled.
YorikSar
force-pushed
the
disable-p2p-default
branch
2 times, most recently
from
868ec9d to
412825a
Compare
Current snapshot is already gone from the bucket.
YorikSar
force-pushed
the
disable-p2p-default
branch
from
412825a to
6b607a3
Compare
Makes it fail on HTTP errors instead of finishing successfully and outputting garbage to out file.
Following the example from input-output-hk/cardano-configurations@319805a create _p2p directories for networks that might have p2p enabled, but keep it off by default.
YorikSar
force-pushed
the
disable-p2p-default
branch
from
6b607a3 to
81af3e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the example from input-output-hk/cardano-configurations@319805a create _p2p directories for networks that might have p2p enabled, but keep it off by default.