Fix 1.44 compatibility #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keep in mind the wiki this extension was made for is still on MW 1.39, even though the admins there have stated they plan an upgrade to 1.43 |
Use the namespaced Html class on MW >= 1.40.
Contributor
Author
Thanks, I was not aware of that. I've updated the PR to support both MW 1.39 and MW 1.44. |
Contributor
Author
|
@Kenny2github @jacob-g Hi, in case you didn't see this PR, would you be able to review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the namespaced Html class on MW >= 1.40.
Downstream task: https://issue-tracker.miraheze.org/T14247