-
-
Notifications
You must be signed in to change notification settings - Fork 18
phreaknet.sh: more openSUSE compatibility patches #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a check for openSUSE Leap in the package manager detector section.
openSUSE uses a different path format for kernel headers that was not checked for by install_kernel_headers(), resulting in an error. This commit adds detection for these paths.
In openSUSE, one of the "kernel-*-devel" packages is required to build kernel modules, otherwise PhreakScript fails to find the kernel build directory. This commit adds the "default" version (a safe assumption, given it's for the standard kernel) of this package to the list of kernel module-related packages that zypper is told to install.
openSUSE does not place kernel build directories in /usr/lib/linux-kbuild-*. This commit adds a check for /usr/src/linux-*, where it is located, in case the first path doesn't exist.
…y code I forgot a newline in the "no build directory found" message, so I added one.
Because autoconf wasn't installed, the DAHDI tools installation failed, so I added it to the list of packages.
…n unsupported modules. After installing libtool and automake, DAHDI finally built sucessfully, so I added them to the prereqs. I also discovered that openSUSE disables the loading of "unsupported" (i.e. external, not signed by SUSE) kernel modules, so I added a message that displays on zypper-based systems that have installed DAHDI that tells the user how to enable loading them, otherwise DAHDI won't work.
htravis123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I placed the packages in the main prerequisite list to match the existing code. The branches for the other package managers also install the same packages regardless of whether or not DAHDI was selected to be installed, so I figured I'd do the same here.
You're right, it's not consistent... hardly surprising given how organically this has grown. I'll let it pass for now, there are some upcoming changes to Asterisk that will require autotools when building from Git now, so it's not the end of the world if they get installed. |
InterLinked1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing autotools packages on all path okay for now
This pull request fixes several problems that were preventing DAHDI from installing/working properly on openSUSE Leap 16.0 (though it may help for other releases of Leap, as well as Tumbleweed; it's just that Leap 16.0 is what I have on hand).
In commit order: