Assignment6 lambda expressions: Build Test #76
Conversation
Followed instructions for program class I think it's done.
Work that I've done for assignment 6
Changes to be committed:
new file: .vscode/launch.json
- For some reason my C# Env was bugging out until I did this step.
modified: Calculate..sln
- reconfiguration to include new Calculator and CalculatorTests projects.
new file: Calculate.Tests/CalculatorTests.cs
- Added unit tests for mathematical operations and calculation logic.
new file: Calculate/Calculator.cs
- Implemented basic arithmetic operations using lambda expressions.
There was a problem hiding this comment.
Create a Console project called "Calculate.". ✔
Define a Program Class
Define two init-only setter properties, WriteLine and ReadLine, that contain delegates for writing a line of text and reading a line of text respectively ✔
Write a test that sets these properties at construction time and then invokes the properties and verifies the expected behavior occurs. ✔
Set the default behavior for the WriteLine and ReadLine properties to invoke System.Console versions of the methods and add an empty default constructor. ✔
Define a Calculator class ✔
Define static Add, Subtract, Multiple, and Divide methods that have two parameters and return a third parameter. ✔
Define a read-only property, MathematicalOperations, of type System.Collections.Generics.IReadOnlyDictionary<TKey,TValue> that:
is initialized to a System.Collections.Generics.Dictionary<<TKey,TValue> instance that. ✔
Uses char for the key corresponding to the operators +, -, *, and /. ✔
Has values that correspond with the Add, Subtract, Multiple, and Divide methods. ✔
Implement a TryCalculate method following "TryParse" pattern ✔
Valid calculation expressions include such strings as "3 + 4", "42 - 2", etc. ✔
If there is no whitespace around the operator, you can assume the calculation is invalid and return false. Similarly if the operands are not integers. ✔
Use string.Split(), pattern matching, logical and operators to parse the string in their entirety ✔
Index into the MathematicalOperations method using the operator parsed during pattern matching to find the corresponding implementation and invoke it. ✔
Implement the Program class to instantiate the calculator and invoke it based on user input from the console. ✔
Be sure to use the WriteLine/ReadLine properties on Program for testing the input and output of your program. ✔
Place all shared project properties into a Directory.Build.props file. ✔
Place all shared project items into a Directory.Build.targets file. (optional)
nullable reference types is enabled ✔
Ensure that you turn on code analysis for all projects(EnableNETAnalyzers) ✔
Set LangVersion and the TargetFramework to the latest released versions available (preview versions optional) ✔
and enabled .NET analyzers for both projects ✔
For this assignment, always use Assert.AreEqual() (the generic version) ✔
All of the above should be unit tested ✔
Choose simplicity over complexity ✔
Great work!
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| program.WriteLine("Invalid calculation. Use format: number operator number (e.g., '3 + 4')"); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Nitpick: You can remove these extra blank lines to keep the formatting consistent.
There was a problem hiding this comment.
I respect that, is that more of a stylistic choice or?
There was a problem hiding this comment.
Since its not gonna break the program; I'm gonna put this on the back burner
ulises-aguilar
left a comment
ulises-aguilar
left a comment
There was a problem hiding this comment.
Create a Console project called "Calculate". ✔
Define a Program Class
Define two init-only setter properties, WriteLine and ReadLine, that contain delegates for writing a line of text and reading a line of text respectively ✔
Write a test that sets these properties at construction time and then invokes the properties and verifies the expected behavior occurs. ✔
Set the default behavior for the WriteLine and ReadLine properties to invoke System.Console versions of the methods and add an empty default constructor. ✔
Define a Calculator class ✔
Define static Add, Subtract, Multiply, and Divide methods that have two parameters and return a third parameter. ✔
Define a read-only property, MathematicalOperations, of type System.Collections.Generics.IReadOnlyDictionary<TKey,TValue> that:
is initialized to a System.Collections.Generics.Dictionary<<TKey,TValue> instance that. ✔
Uses char for the key corresponding to the operators +, -, *, and /. ✔
Has values that correspond with the Add, Subtract, Multiply, and Divide methods. ✔
Implement a TryCalculate method following "TryParse" pattern ✔
Valid calculation expressions include such strings as "3 + 4", "42 - 2", etc. ✔
If there is no whitespace around the operator, you can assume the calculation is invalid and return false. Similarly if the operands are not integers. ✔
Use string.Split(), pattern matching, logical and operators to parse the string in their entirety ✔
Index into the MathematicalOperations method using the operator parsed during pattern matching to find the corresponding implementation and invoke it. ✔
Implement the Program class to instantiate the calculator and invoke it based on user input from the console. ✔
Be sure to use the WriteLine/ReadLine properties on Program for testing the input and output of your program. ✔
|
Reviewed EACH AND EVERY PIECE OF FEEDBACK HERE. I addressed and responded to each one either seekng clarification or asking questions... |
thigiang16
left a comment
thigiang16
left a comment
There was a problem hiding this comment.
Instructions
Create a Console project called "Calculate". ✔
Define a Program Class
Define two init-only setter properties, WriteLine and ReadLine, that contain delegates for writing a line of text and reading a line of text respectively ✔
Write a test that sets these properties at construction time and then invokes the properties and verifies the expected behavior occurs. ✔
Set the default behavior for the WriteLine and ReadLine properties to invoke System.Console versions of the methods and add an empty default constructor. ✔
Define a Calculator class ✔
Define static Add, Subtract, Multiply, and Divide methods that have two parameters and return a third parameter. ✔
Define a read-only property, MathematicalOperations, of type System.Collections.Generics.IReadOnlyDictionary<TKey,TValue> that:
is initialized to a System.Collections.Generics.Dictionary<<TKey,TValue> instance that. ✔
Uses char for the key corresponding to the operators +, -, *, and /. ✔
Has values that correspond with the Add, Subtract, Multiply, and Divide methods. ✔
Implement a TryCalculate method following "TryParse" pattern ✔
Valid calculation expressions include such strings as "3 + 4", "42 - 2", etc. ✔
If there is no whitespace around the operator, you can assume the calculation is invalid and return false. Similarly if the operands are not integers. ✔
Use string.Split(), pattern matching, logical and operators to parse the string in their entirety ✔
Index into the MathematicalOperations method using the operator parsed during pattern matching to find the corresponding implementation and invoke it. ✔
Implement the Program class to instantiate the calculator and invoke it based on user input from the console. ✔
Be sure to use the WriteLine/ReadLine properties on Program for testing the input and output of your program. ✔
Extra Credit
Do one of the following two options (or both if you want extra, extra credit) :)
Refactor the redirect portion of the Program class into 'ProgramBase` ❌
Move ProgramBase into a ConsoleUtilities assembly to be used in other console-based projects ❌
Use generics the mathematical operations methods and consider using generic constraints (requires .NET 7.0) ❌
Fundamentals
Place all shared project properties into a Directory.Build.props file.
Place all shared project items into a Directory.Build.targets file. (optional)
nullable reference types is enabled ✔
Ensure that you turn on code analysis for all projects(EnableNETAnalyzers) ✔
Set LangVersion and the TargetFramework to the latest released versions available (preview versions optional) ✔
and enabled .NET analyzers for both projects ✔
For this assignment, always use Assert.AreEqual() (the generic version) ✔
All of the above should be unit tested ✔
Choose simplicity over complexity ✔
Overall, everything looks good! The program is clear, simple, and well-tested!
Calculate/Calculator.cs
Outdated
| { | ||
|
|
||
| result = 0; | ||
| var parts = calculation.Split(' '); |
There was a problem hiding this comment.
What you implemented looks good! You can make it a bit safer by using var parts = calculation.Split(' ', StringSplitOptions.RemoveEmptyEntries); instead of splitting on a single space. This way, extra spaces in the input won’t break the calculation
Calculate.Tests/CalculatorTests.cs
Outdated
| } | ||
|
|
||
| [TestMethod] | ||
| public void TryCalculate_ExtraSpaces_ReturnsFalse() |
There was a problem hiding this comment.
The suggestion I mentioned earlier would make this test pass with extra spaces but I don’t think handling extra spaces is part of the requirements, so you can just take it as an optional suggestion
There was a problem hiding this comment.
Yeah the instructions say that the operand has to have spaces around it and that's it, but since it's a quick implementation and test change I implemented it. I don't see how it could LOSE points making the program more robust and not work with little user errors like adding an extra space.
Calculate/Calculator.cs
Outdated
| { | ||
| public static int Add(int a, int b) => a + b; | ||
| public static int Subtract(int a, int b) => a - b; | ||
| public static int Multiple(int a, int b) => a * b; |
There was a problem hiding this comment.
Maybe rename Multiple to Multiply just in case. It might lose points since it doesn't exactly follow the instructions...
Added option to the split function in trycalculate to remove empty entries
SummarySummary
CoverageCalculate. - 96%
|
|
Don't know why GitHub isn't letting me resolve conversations but all comments have been addressed. |
Joshua-Lester3
left a comment
Joshua-Lester3
left a comment
There was a problem hiding this comment.
Instructions
- Create a Console project called "Calculate". ✔
- Define a Program Class
- Define two init-only setter properties,
WriteLineandReadLine, that contain delegates for writing a line of text and reading a line of text respectively ✔ - Write a test that sets these properties at construction time and then invokes the properties and verifies the expected behavior occurs. ✔
- Set the default behavior for the
WriteLineandReadLineproperties to invokeSystem.Consoleversions of the methods and add an empty default constructor. ✔
- Define two init-only setter properties,
- Define a Calculator class ✔
- Define static
Add,Subtract,Multiply, andDividemethods that have two parameters and return a third parameter. ❌ It's a little nit-picky, but I'm assuming third parameter means having a third parameter labeledout. That's my interpretation of 'returning a parameter'. - Define a read-only property,
MathematicalOperations, of typeSystem.Collections.Generics.IReadOnlyDictionary<TKey,TValue>that:- is initialized to a
System.Collections.Generics.Dictionary<<TKey,TValue>instance that. ✔- Uses
charfor the key corresponding to the operators +, -, *, and /. ✔ - Has values that correspond with the Add, Subtract, Multiply, and Divide methods. ✔
- Uses
- is initialized to a
- Implement a
TryCalculatemethod following "TryParse" pattern ✔- Valid
calculationexpressions include such strings as "3 + 4", "42 - 2", etc. ✔ - If there is no whitespace around the operator, you can assume the
calculationis invalid and return false. Similarly if the operands are not integers. ✔ - Use
string.Split(), pattern matching, logical and operators to parse the string in their entirety ✔ - Index into the
MathematicalOperationsmethod using the operator parsed during pattern matching to find the corresponding implementation and invoke it. ✔
- Valid
- Define static
- Implement the Program class to instantiate the calculator and invoke it based on user input from the console. ✔
- Be sure to use the
WriteLine/ReadLineproperties onProgramfor testing the input and output of your program. ✔
Extra Credit
Do one of the following two options (or both if you want extra, extra credit) :)
- Refactor the redirect portion of the
Programclass into 'ProgramBase` ❌- Move ProgramBase into a ConsoleUtilities assembly to be used in other console-based projects
- Use generics the mathematical operations methods and consider using generic constraints (requires .NET 7.0) ❌
Fundamentals
- Place all shared project properties into a
Directory.Build.propsfile. - Place all shared project items into a
Directory.Build.targetsfile. (optional) - nullable reference types is enabled ✔
- Ensure that you turn on code analysis for all projects(EnableNETAnalyzers) ✔
- Set LangVersion and the TargetFramework to the latest released versions available (preview versions optional) ✔
- and enabled .NET analyzers for both projects ✔
- For this assignment, always use
Assert.AreEqual<T>()(the generic version) ✔ - All of the above should be unit tested ✔
- Choose simplicity over complexity ✔
| parts[1].Length != 1 || | ||
| !int.TryParse(parts[0], out int left) || | ||
| !int.TryParse(parts[2], out int right) || | ||
| !MathematicalOperations.TryGetValue(parts[1][0], out var operation)) |
There was a problem hiding this comment.
I'd specify the type instead of var here. So Func<int, int, int>. There's a guideline or convention that when the type isn't immediately obvious to specify it - I'd say that applies here.
|
|
||
| program.WriteLine("Enter calculation (e.g., '3 + 4') or 'exit' to quit:"); | ||
|
|
||
| while (true) |
There was a problem hiding this comment.
Consider that having an infinite loop creates a certain kind of interactive experience like a REPL vs if you did not have the loop the app would exit on each invocation and could be used like in an automated tool call fashion.
| private static readonly string[] ExitCommandVariations = new[] { "EXIT", "exit", "Exit" }; | ||
|
|
||
| // Lock object to prevent parallel test execution from interfering with Console redirection | ||
| private static readonly object ConsoleLock = new(); |
There was a problem hiding this comment.
Good job putting a comment on why this lock exists, however, I can't put my finger on it but something does not smell right here. It seems like you might not need a lock, you want to try to isolate the tests as much as possible.
|
|
||
| // Assert | ||
| Assert.HasCount(3, outputs); | ||
| Assert.AreEqual<string>("First", outputs[0]); |
There was a problem hiding this comment.
nit: you typically only want a single assertion so that the test fails for a specific reason.
| parts[1].Length != 1 || | ||
| !int.TryParse(parts[0], out int left) || | ||
| !int.TryParse(parts[2], out int right) || | ||
| !MathematicalOperations.TryGetValue(parts[1][0], out var operation)) |
There was a problem hiding this comment.
In the instructions it mentions to "Index into the MathematicalOperations method using the operator parsed during pattern matching to find the corresponding implementation and invoke it."
| } | ||
|
|
||
| // prevent division by zero | ||
| if (parts[1][0] == '/' && right == 0) |
There was a problem hiding this comment.
Consider using the MathematicalOperations division key instead of hard coding this here.
7 participants
Worked with Ryan Hirte