Skip to content

Primitives should not be boxed just for "String" conversion #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AymanDF wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Primitives should not be boxed just for "String" conversion #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion oneSheeld/src/main/java/com/integreight/onesheeld/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ public void onClick(View v) {
}
getThisApplication().getTracker().send(
new HitBuilders.ScreenViewBuilder()
.setCustomDimension(2, version + "")
.setCustomDimension(2, String.valueOf(version))
.build());
}
});
Expand Down
4 changes: 2 additions & 2 deletions oneSheeld/src/main/java/com/integreight/onesheeld/model/InternetRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,15 +179,15 @@ public void onFinish() {

public InternetResponse getResponse() {
try {
return InternetManager.getInstance().getCachDB().get(id + "", InternetResponse.class);
return InternetManager.getInstance().getCachDB().get(String.valueOf(id), InternetResponse.class);
} catch (SnappydbException e) {
return null;
}
}

public void setResponse(InternetResponse response) {
try {
InternetManager.getInstance().getCachDB().put(id + "", response);
InternetManager.getInstance().getCachDB().put(String.valueOf(id), response);
} catch (SnappydbException e) {
e.printStackTrace();
}
Expand Down
2 changes: 1 addition & 1 deletion oneSheeld/src/main/java/com/integreight/onesheeld/popup/FirmwareUpdatingPopup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ public void onFailure(int statusCode,
Throwable error) {
changeSlogan("Error Downloading!", COLOR.RED);
setUpgrade();
Log.d("bootloader", statusCode + "");
Log.d("bootloader", String.valueOf(statusCode));
activity.getThisApplication()
.getTracker()
.send(new HitBuilders.EventBuilder()
Expand Down
24 changes: 12 additions & 12 deletions oneSheeld/src/main/java/com/integreight/onesheeld/shields/controller/ClockShield.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ public void run() {
frame.addByteArgument((byte) calendar.get(Calendar.SECOND));
sendShieldFrame(frame);
}
String hour = calendar.get(Calendar.HOUR_OF_DAY) + "";
String min = calendar.get(Calendar.MINUTE) + "";
String sec = calendar.get(Calendar.SECOND) + "";
String hour = String.valueOf(calendar.get(Calendar.HOUR_OF_DAY));
String min = String.valueOf(calendar.get(Calendar.MINUTE));
String sec = String.valueOf(calendar.get(Calendar.SECOND));
if (eventHandler != null)
eventHandler.onTimeChanged(""
+ (hour.length() == 1 ? "0" + hour : hour) + ":"
Expand Down Expand Up @@ -78,9 +78,9 @@ public ControllerParent<ControllerParent<ClockShield>> init(String tag) {

// frame.addByteArgument((byte) year);
sendShieldFrame(frame);
String hour = calendar.get(Calendar.HOUR_OF_DAY) + "";
String min = calendar.get(Calendar.MINUTE) + "";
String sec = calendar.get(Calendar.SECOND) + "";
String hour = String.valueOf(calendar.get(Calendar.HOUR_OF_DAY));
String min = String.valueOf(calendar.get(Calendar.MINUTE));
String sec = String.valueOf(calendar.get(Calendar.SECOND));
if (eventHandler != null)
eventHandler.onTimeChanged(""
+ (hour.length() == 1 ? "0" + hour : hour) + ":"
Expand Down Expand Up @@ -127,9 +127,9 @@ public void onNewShieldFrameReceived(ShieldFrame clock_frame) {

// frame.addByteArgument((byte) year);
sendShieldFrame(frame);
String hour = calendar.get(Calendar.HOUR_OF_DAY) + "";
String min = calendar.get(Calendar.MINUTE) + "";
String sec = calendar.get(Calendar.SECOND) + "";
String hour = String.valueOf(calendar.get(Calendar.HOUR_OF_DAY));
String min = String.valueOf(calendar.get(Calendar.MINUTE));
String sec = String.valueOf(calendar.get(Calendar.SECOND));
if (eventHandler != null)
eventHandler.onTimeChanged(""
+ (hour.length() == 1 ? "0" + hour : hour) + ":"
Expand Down Expand Up @@ -281,9 +281,9 @@ public void onReceive(Context context, Intent intent) {
}
}
setTime();
String hour = calendar.get(Calendar.HOUR_OF_DAY) + "";
String min = calendar.get(Calendar.MINUTE) + "";
String sec = calendar.get(Calendar.SECOND) + "";
String hour = String.valueOf(calendar.get(Calendar.HOUR_OF_DAY));
String min = String.valueOf(calendar.get(Calendar.MINUTE));
String sec = String.valueOf(calendar.get(Calendar.SECOND));
if (eventHandler != null)
eventHandler.onTimeChanged(
"" + (hour.length() == 1 ? "0" + hour : hour) + ":"
Expand Down
4 changes: 2 additions & 2 deletions oneSheeld/src/main/java/com/integreight/onesheeld/shields/controller/DataLoggerShield.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ public void saveData() {
folder.mkdirs();
}
fullFileName = (fileName == null
|| fileName.length() == 0 ? new Date()
.getTime() + ""
|| fileName.length() == 0 ? String.valueOf(new Date()
.getTime())
: fileName + " - " + new Date()
.getTime()) + ".csv";
filePath = Environment
Expand Down
6 changes: 3 additions & 3 deletions ...eeld/src/main/java/com/integreight/onesheeld/shields/fragments/AccelerometerFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,23 +87,23 @@ public void onSensorValueChangedFloat(final float[] value) {
@Override
public void run() {
if (canChangeUI())
x.setText("" + value[0]);
x.setText(String.valueOf(value[0]));
}
});
y.post(new Runnable() {

@Override
public void run() {
if (canChangeUI())
y.setText("" + value[1]);
y.setText(String.valueOf(value[1]));
}
});
z.post(new Runnable() {

@Override
public void run() {
if (canChangeUI())
z.setText("" + value[2]);
z.setText(String.valueOf(value[2]));

}
});
Expand Down
6 changes: 3 additions & 3 deletions oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/GravityFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,23 +79,23 @@ public void onSensorValueChangedFloat(final float[] value) {
@Override
public void run() {
if (canChangeUI())
x.setText("" + value[0]);
x.setText(String.valueOf(value[0]));
}
});
y.post(new Runnable() {

@Override
public void run() {
if (canChangeUI())
y.setText("" + value[1]);
y.setText(String.valueOf(value[1]));
}
});
z.post(new Runnable() {

@Override
public void run() {
if (canChangeUI())
z.setText("" + value[2]);
z.setText(String.valueOf(value[2]));

}
});
Expand Down
6 changes: 3 additions & 3 deletions oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/GyroscopeFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,23 +81,23 @@ public void onSensorValueChangedFloat(final float[] value) {
@Override
public void run() {
if (canChangeUI())
x.setText("" + value[0]);
x.setText(String.valueOf(value[0]));
}
});
y.post(new Runnable() {

@Override
public void run() {
if (canChangeUI())
y.setText("" + value[1]);
y.setText(String.valueOf(value[1]));
}
});
z.post(new Runnable() {

@Override
public void run() {
if (canChangeUI())
z.setText("" + value[2]);
z.setText(String.valueOf(value[2]));

}
});
Expand Down
6 changes: 3 additions & 3 deletions ...heeld/src/main/java/com/integreight/onesheeld/shields/fragments/MagnetometerFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,23 +83,23 @@ public void onSensorValueChangedFloat(final float[] value) {
@Override
public void run() {
if (canChangeUI())
x.setText("" + value[0]);
x.setText(String.valueOf(value[0]));
}
});
y.post(new Runnable() {

@Override
public void run() {
if (canChangeUI())
y.setText("" + value[1]);
y.setText(String.valueOf(value[1]));
}
});
z.post(new Runnable() {

@Override
public void run() {
if (canChangeUI())
z.setText("" + value[2]);
z.setText(String.valueOf(value[2]));

}
});
Expand Down
6 changes: 3 additions & 3 deletions oneSheeld/src/main/java/com/integreight/onesheeld/shields/fragments/OrientationFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,23 +82,23 @@ public void onSensorValueChangedFloat(final float[] value) {
@Override
public void run() {
if (canChangeUI())
x.setText("" + value[0]);
x.setText(String.valueOf(value[0]));
}
});
y.post(new Runnable() {

@Override
public void run() {
if (canChangeUI())
y.setText("" + value[1]);
y.setText(String.valueOf(value[1]));
}
});
z.post(new Runnable() {

@Override
public void run() {
if (canChangeUI())
z.setText("" + value[2]);
z.setText(String.valueOf(value[2]));

}
});
Expand Down