Fix the SPM build errors caused by removal of unprefixed headers #1644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
@TimOliver has imported this pull request. If you are a Meta employee, you can view this in D86943807. |
Contributor
|
@TimOliver has updated the pull request. You must reimport the pull request before landing. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
@TimOliver merged this pull request in 98bd6c6. |
TimOliver
added a commit
that referenced
this pull request
Dec 10, 2025
Summary: It looks like D86316341 caused the GitHub unit tests to stop passing since SPM relies on IGListKit and IGListDiffKit being in the same directory so there are no module imports. This diff adds the same `__has_include` conditional checking so our internal and external module configurations will both work. Pull Request resolved: #1644 Test Plan: The external tests are working again. As long as the internal tests also pass, we should be good! {F1983488354} Reviewed By: m3rlin45 Differential Revision: D86943807 Pulled By: TimOliver fbshipit-source-id: c741acbb1f8425e92834daec720d4be3b3c264da
TimOliver
added a commit
that referenced
this pull request
Dec 10, 2025
Summary: It looks like D86316341 caused the GitHub unit tests to stop passing since SPM relies on IGListKit and IGListDiffKit being in the same directory so there are no module imports. This diff adds the same `__has_include` conditional checking so our internal and external module configurations will both work. Pull Request resolved: #1644 Test Plan: The external tests are working again. As long as the internal tests also pass, we should be good! {F1983488354} Reviewed By: m3rlin45 Differential Revision: D86943807 Pulled By: TimOliver fbshipit-source-id: c741acbb1f8425e92834daec720d4be3b3c264da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like c38d8f caused the unit tests to stop passing since SPM relies on file traversal to find the associated IGListDiffKit files from the IGListKit build target.
I'll add in the conditional import checks we were using in other parts of library to fix this