[CI] Refactor cog unit test GHA workflow #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit basically brings in SFUAnime/Ren#673 to replace the existing cog unit test GHA (GitHub Actions) workflow. This commit is identical to the said pull request, except: - The `master` branch is the only branch that this workflow will get triggered on. - The cogs relative path is set to `.` because the repo (bearing this commit) has cogs at its root level.
There is no `setup.py` so this commit adds a new field `min_bot_version` in `info.json` and also adds a fallback version of "3.4.0" in the workflow file iself. See https://docs.discord.red/en/stable/guide_publish_cogs.html for more details about `min_bot_version`. This field is supposed to be defined for cogs only, not for cog repos, but at the very least, it is a good central place to define the Red bot version for the cog repo.
This change fixes the cog unit test GHA workflow by adding the path `"info.json"` as a positional argument to the `jq` command in the "extract Red version" step.
This commit fixes it by correcting the text output to `$GITHUB_OUTPUT` as it has to be in the form of `key=value`.
It was initially 3.4.0 just because the commit stack was brought over from the `master` branch meant for Red <3.5.0.
It was initially `master` just because the commit stack was brought over from the `master` branch.
The Pytest version required by Red bot 3.5.0 only supports `-c` and does not support `--config-file`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit basically brings in
SFUAnime/Ren#673 to replace the existing cog unit test GHA (GitHub Actions) workflow.
This commit is identical to the said pull request, except:
dpy2branch is the only branch that this workflow will get triggered on..because the repo (bearing this commit) has cogs at its root level.setup.pyor anything of the Red bot repo in this cog repo. The workflow file has aFALLBACK_BOT_VERSIONenvironment variable set to 3.5.0, and theinfo.jsonfile at the root level of the repo has a JSON keymin_bot_versionset to value"3.5.0"as well. This ensures that the Red bot version is at least defined somewhere logical and sensible to maintainers. See https://docs.discord.red/en/stable/guide_publish_cogs.html for more details aboutmin_bot_version. This field is supposed to be defined for cogs only, not for cog repos, but at the very least, it is a good central place to define the Red bot version for the cog repo.