Skip to content

Support for user defined comments per file #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jenschude wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support for user defined comments per file #100

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f09cf8e
Support for user defined comments per file
Apr 11, 2016
f1118d1
fix for PHP 5.3
Apr 11, 2016
e5a5588
add tests for comment option
Apr 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Processor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ private function processParams(array $config, array $expectedParams, array $actu
// Add the params coming from the environment values
$actualParams = array_replace($actualParams, $this->getEnvValues($envMap));

return $this->getParams($expectedParams, $actualParams);
return $this->getParams($expectedParams, $actualParams, $config);
}

private function getEnvValues(array $envMap)
Expand Down Expand Up @@ -137,7 +137,7 @@ private function processRenamedValues(array $renameMap, array $actualParams)
return $actualParams;
}

private function getParams(array $expectedParams, array $actualParams)
private function getParams(array $expectedParams, array $actualParams, array $config = array())
{
// Simply use the expectedParams value as default for the missing params.
if (!$this->io->isInteractive()) {
Expand All @@ -153,7 +153,11 @@ private function getParams(array $expectedParams, array $actualParams)

if (!$isStarted) {
$isStarted = true;
$this->io->write('<comment>Some parameters are missing. Please provide them.</comment>');
if (empty($config['comment'])) {
$this->io->write('<comment>Some parameters are missing. Please provide them.</comment>');
} else {
$this->io->write('<comment>' . $config['comment'] . '</comment>');
Copy link

@OskarStark OskarStark Apr 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would use sprintf() here

}
}

$default = Inline::dump($message);
Expand Down