Skip to content

Re-enable some skipped tests. #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knirirr merged 2 commits into from
Nov 3, 2025
Merged

Re-enable some skipped tests. #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
836776d
Re-enable some skipped tests.
knirirr Oct 31, 2025
faa935d
Merge branch 'develop' into further_test_cleanup
proccaserra Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/convert/test_isatab2sra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ def test_isatab2sra_dump_submission_xml_biis7(self):
actual_submission_xml_biis7 = etree.fromstring(submission_xml)
self.assertTrue(utils.assert_xml_equal(self._expected_submission_xml_biis7, actual_submission_xml_biis7))

# @unittest.skip("Not working yet")
def test_isatab2sra_dump_project_set_xml_biis7(self):
isatab2sra.convert(self._biis7_dir, self._tmp_dir, validate_first=False)
with open(os.path.join(self._tmp_dir, "project_set.xml"), "rb") as ps_fp:
Expand Down
7 changes: 2 additions & 5 deletions tests/convert/test_sampletab2isatab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
from isatools.convert import sampletab2isatab
from isatools.tests import utils

SLOW_TESTS = int(os.getenv("SLOW_TESTS", "0"))


def setUpModule():
if not os.path.exists(utils.DATA_DIR):
Expand Down Expand Up @@ -35,17 +33,16 @@ def test_sampletab2isatab_test_2(self):
with open(os.path.join(self._sampletab_dir, "test2.txt")) as sampletab_fp:
sampletab2isatab.convert(source_sampletab_fp=sampletab_fp, target_dir=self._tmp_dir)

@unittest.skipIf(not SLOW_TESTS, "slow")
@unittest.skip("deprecated method pending deletion")
def test_sampletab2isatab_GSB_3(self):
with open(os.path.join(self._sampletab_dir, "GSB-3.txt")) as sampletab_fp:
sampletab2isatab.convert(source_sampletab_fp=sampletab_fp, target_dir=self._tmp_dir)

@unittest.skipIf(not SLOW_TESTS, "slow")
@unittest.skip("deprecated method pending deletion")
def test_sampletab2isatab_GSB_537(self):
with open(os.path.join(self._sampletab_dir, "GSB-537.txt")) as sampletab_fp:
sampletab2isatab.convert(source_sampletab_fp=sampletab_fp, target_dir=self._tmp_dir)

@unittest.skip("slow")
def test_sampletab2isatab_GSB_718(self):
with open(os.path.join(self._sampletab_dir, "GSB-718.txt")) as sampletab_fp:
sampletab2isatab.convert(source_sampletab_fp=sampletab_fp, target_dir=self._tmp_dir)
6 changes: 3 additions & 3 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading