check_isa_schemas updated to new json validator. #591 #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proccaserra
reviewed
Oct 25, 2025
Member
proccaserra
left a comment
proccaserra
left a comment
There was a problem hiding this comment.
failure of tests is down to this schema which mandates "format" to be email.
"email" : { "type" : "string", "format" : "email"},
trying: "email" : { "type" : ["string", null], "format" : "email"}, does not fix it.
quick fix is relaxing requirement: "email" : { "type" : "string"}, but this is cheeky
alternative: fix test data so email is always present to json schema validation passes
worth having a chat with MetaboLights (@oyerulten) & users
…ot security issues
Deprecation warnings prs
proccaserra
approved these changes
Oct 27, 2025
Member
proccaserra
left a comment
proccaserra
left a comment
There was a problem hiding this comment.
looks good to me and all points addressed following our discussion. thx @knirirr
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dealing with some warnings related to JSON validation.