Update ios.yml with new device and OS version#308
Merged
alexianunez merged 11 commits intomainfrom Apr 2, 2025
Merged
Conversation
ssathy2
reviewed
Apr 2, 2025
.github/workflows/ios.yml
Outdated
Comment on lines
+21
to
+22
| os: ${{ '18.1' }} | ||
| device: ${{ 'iPhone 16' }} |
Contributor
There was a problem hiding this comment.
I think we can just delete these. What happens if you don't include them?
Contributor
There was a problem hiding this comment.
These params are used in the xcodebuild invocation build later in the script so that command will fail. Instead, we should update the xcodebuild command to use whatever the latest os version is. Can you make that update?
ssathy2
reviewed
Apr 2, 2025
.github/workflows/ios.yml
Outdated
Comment on lines
+31
to
+43
| # Find latest available iOS runtime identifier | ||
| latest_runtime_id=$(xcrun simctl list runtimes | grep -E "iOS [0-9]+\.[0-9]*" | grep -v unavailable | sort -Vr | head -n 1 | sed -E 's/.*- (.*)$/\1/') | ||
|
|
||
| # Find a compatible simulator device name for that runtime | ||
| device_name=$(xcrun simctl list devices available | grep "$latest_runtime_id" | head -n 1 | sed -E 's/^ (.+) \(.+\) \(.+\)$/\1/') | ||
|
|
||
| if [ -z "$latest_runtime_id" ] || [ -z "$device_name" ]; then | ||
| echo "❌ Failed to find a valid iOS runtime or device." | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "🛠 Using runtime: $latest_runtime_id" | ||
| echo "📱 Using device: $device_name" |
Contributor
There was a problem hiding this comment.
It might be simpler to use xcrun to get the available devices and picking the very first iPhone simulator on that list:
device_name=$(xcrun simctl list devices available | grep "iPhone" | head -n 1 | sed -E 's/^[[:space:]]*(.+) \(.+\) \(.+\)$/\1/')
Then your xcodebuild invocation would look something like:
# Build and run the tests
xcodebuild test \
-scheme "$scheme" \
-"$filetype_parameter" "$file_to_build" \
-destination "platform=iOS Simulator,name=$device_name"
ssathy2
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.