fix(build): include test/utils/*.py in sdist #229
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this because Debian's packaging is based on the sdist from PyPI, but tests failed because `test/utils/` wasn't distributed there. (See https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html for the default behaviour.) Signed-off-by: Colin Watson <cjwatson@debian.org>
|
|
Signed-off-by: Colin Watson <cjwatson@debian.org>
Contributor
Author
|
I think I'll probably switch the packaging to use archives from git instead, but these changes do still seem correct to me. |
pyrooka
approved these changes
Jan 28, 2026
Member
pyrooka
left a comment
pyrooka
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Just took a look at the PR and went through the documentation and the change looks correct to me.
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jan 28, 2026
## [3.24.3](v3.24.2...v3.24.3) (2026-01-28) ### Bug Fixes * **build:** include test/utils/*.py and test resources in sdist ([#229](#229)) ([802255b](802255b))
|
🎉 This PR is included in version 3.24.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this because Debian's packaging is based on the sdist from PyPI, but tests failed because
test/utils/wasn't distributed there. (See https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html for the default behaviour.)