Draft
Conversation
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
matancarmeli7
requested review from
ArbelNathan,
annaparienti,
barakda,
oriyarde,
roysahar and
tyichye19
ArbelNathan
reviewed
Nov 25, 2021
| app.kubernetes.io/instance: ibm-block-csi-operator | ||
| app.kubernetes.io/managed-by: ibm-block-csi-operator | ||
| product: ibm-block-csi-driver | ||
| app.kubernetes.io/name: ibm-block-csi-operator |
Contributor
There was a problem hiding this comment.
most of the diff looks like "rearranging lines", can we avoid it so the diff will be minimal?
Contributor
Author
There was a problem hiding this comment.
I needed to do it since our yamls weren't aligned and that the CI won't fail, it will be easier for you if I will separate the PR's? one PR will be the yamls diffs and the other one will be the scripts that check it
Contributor
There was a problem hiding this comment.
yes, that would be great!
Contributor
Author
roysahar
reviewed
Nov 28, 2021
| ARG YQ_VERSION=v4.13.5 | ||
| ARG ARCH=yq_linux_386 | ||
| RUN ARCH=$(if [ "$(uname -m)" = "x86_64" ]; then echo "amd64"; else echo "$(uname -m)" ; fi) \ | ||
| && wget https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/yq_linux_${ARCH} -O /usr/bin/yq \ |
Contributor
There was a problem hiding this comment.
@matancarmeli7 you can use go get - https://github.com/mikefarah/yq#go-get
roysahar
reviewed
Nov 28, 2021
oriyarde
reviewed
Nov 30, 2021
oriyarde
reviewed
Nov 30, 2021
oriyarde
reviewed
Nov 30, 2021
| verify_no_roles_diff (){ | ||
| echo "check roles alignment" | ||
| source hack/get_information_helper.sh | ||
| are_manifest_files_exsists_in_current_csi_version |
Contributor
There was a problem hiding this comment.
please:
- address all conversations from PRs with common code
- sync the changes between said PRs so that their common diff is aligned
- change all but one said PRs to "draft", so that we stop doing double work
- when you want to change back a PR from "draft", ensure it is up to date with develop first
oriyarde
reviewed
Nov 30, 2021
Contributor
Author
|
fyi #224 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.