Skip to content

Fix dataset short_name validation #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simon-20 merged 6 commits into from
Jan 15, 2026
Merged

Fix dataset short_name validation #59

simon-20 merged 6 commits into from
Jan 15, 2026

Conversation

@simon-20
Copy link
Contributor

@simon-20 simon-20 commented Jan 14, 2026 •
edited
Loading

This PR adds to the PATCH dataset endpoint:

  • Refactors the PATCH method to use the new assert_precondition_met method
  • Adds string validation for the short_name field (previously any string was permitted)
  • Verifies that the new short_name (if it's been updated) is unique in the Registry

This will resolve #57

@simon-20 simon-20 requested a review from chrisarridge January 14, 2026 10:49
@simon-20
test: add test to validate short_name format
2b159c4
@simon-20
fix: add dataset short_name field validation
2714f80 
This contributes to resolving #57
@simon-20
refactor: use new assert_precondition_met
8255d47
@simon-20
fix: check dataset short_name is unique
0b056df 
When PATCHing the dataset, this fix will check that the
dataset short_name is unique, if the short_name has been
changed from its existing value. This completes the resolution
of #57
@simon-20
doc: update CHANGELOG
0a05d69
@simon-20
build: bump the version
e5177fd
@simon-20 simon-20 force-pushed the sk-fix-dataset-validation-on-update branch from 5f4b046 to e5177fd Compare January 15, 2026 11:35
@simon-20 simon-20 changed the base branch from sk-paging-on-reporting-org to develop January 15, 2026 11:36
@simon-20 simon-20 merged commit 5ce9ace into develop Jan 15, 2026
5 checks passed
@simon-20 simon-20 deleted the sk-fix-dataset-validation-on-update branch January 15, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisarridge chrisarridge chrisarridge approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Validate dataset short name is alphanumeric (with underscores) and is unique on dataset update

3 participants

@simon-20 @chrisarridge