Improved handling for division by zero #943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
=====================================
Coverage 94.8% 94.9%
=====================================
Files 68 68
Lines 6474 6504 +30
=====================================
+ Hits 6143 6173 +30
Misses 331 331 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Also added some refactoring to avoid importing internal methods to remove some formatting-warnings. |
phackstock
reviewed
Nov 25, 2025
Contributor
phackstock
left a comment
phackstock
left a comment
There was a problem hiding this comment.
Looks good to me in principle. As detailed below, I think the two explicit zero checks outside of the series are a bit overkill as you'd get the division by zero error anyway.
phackstock
approved these changes
Nov 26, 2025
Contributor
phackstock
left a comment
phackstock
left a comment
There was a problem hiding this comment.
Good to be merged from my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
PR #937 added safeguards against inf-values in timeseries data, but this can lead to errors when using the
IamDataFrame.divide()method. This PR raises an error when diving by a scalar and drops the offending rows (and prints to log) if dividing the data along an axis.