Add django-stubs as a project dependency + other patches #4278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for better type hints when working with editors that support it. I'm using Zed with pywright linter. The project has type hints here, this help catch issues against the django default types and any custom types that are added to this codebase. This PR also these patch versions of these dependencies Updated anyio v4.6.2.post1 -> v4.7.0 Updated boto3 v1.35.76 -> v1.35.79 Updated botocore v1.35.76 -> v1.35.79 Updated coverage v7.6.8 -> v7.6.9 Updated django-select2 v8.2.1 -> v8.2.3 Updated httpx v0.28.0 -> v0.28.1 Updated mkdocs-material v9.5.47 -> v9.5.48 Updated numpy v2.1.3 -> v2.2.0 Updated sentry-sdk v2.19.0 -> v2.19.2 Updated sqlparse v0.5.2 -> v0.5.3
theskumar
force-pushed
the
django-stubs
branch
from
a2bd44a to
5c00bc5
Compare
frjo
requested changes
Dec 13, 2024
Member
frjo
left a comment
frjo
left a comment
There was a problem hiding this comment.
I think we need to add mypy to the dev dependencies for this to work. At least for my editor, Sublime Text 3.
Member
Author
|
Added mypy as a dev-dependency. |
frjo
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for better type hints when working with editors that support it. I'm using Zed with pywright linter. Recently, some type hints were added to the project. This help catch issues against the django default types and any custom types that are added to this codebase.
This doesn't add any runtime overhead.
This PR also these patch versions of these dependencies
https://github.com/typeddjango/django-stubs