Skip to content

Conversation

@frjo
Copy link
Member

@frjo frjo commented Dec 10, 2024

  • Removed symbol-es6.min.js, not used and we do not support IE since a long time.
  • Removed url-search-params.js, all browsers support URLSearchParams nowadays.
  • Removed all-reviews-table.js, not used anywhere.
  • Removed mobile styling/js toggle of sidebar actions. They are responsive as they are.
  • Replace two-factor-focus.js with one line inline vanilla js.
  • Avoid double adding of file-uploads.js.
  • Avoid double adding of comment_form.media.*.
  • Only load daterangepicker js where it is used on submission/all.
  • Converted file-uploads.js to vanilla js.
  • Use gap on wrapper--sidebar class instead of padding on wrapper--sidebar--inner.
  • Fix bug that made status not show on projects on mobile.

Test Steps

  • Test that all actions in sidebar on submissions, projects, invoices show up as they should on small screens.
  • Test that all file upload fields work as they should.
  • Test that form groups work as they should.
  • Test that comment forms work as they should.

@frjo frjo added Type: Maintenance Type: Patch Mini change, used in release drafter Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 10, 2024
@frjo
Copy link
Member Author

frjo commented Dec 12, 2024

I will stop here, enough things to test as it is.

Will be a part 2.

@wes-otf
Copy link
Contributor

wes-otf commented Dec 13, 2024

Only issue I was seeing on test was with group fields not working - looked like they were revealed from the start. Heres the lab that I was testing with along with the form for that lab. Let me know if I'm missing something - nice changes overall though! excited to have less jquery

@wes-otf wes-otf added Status: Tested - changes/discussion needed 🔨 and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 13, 2024
@frjo frjo force-pushed the maintenance/convert-jquery-to-vanilla branch from 0e3321b to 4195eec Compare December 13, 2024 15:17
@frjo
Copy link
Member Author

frjo commented Dec 13, 2024

@wes-otf You found a bug in form-group-toggle.js. I believe I have fixed it now, new version deploying to test now.

@frjo
Copy link
Member Author

frjo commented Dec 13, 2024

@wes-otf There are more bugs, reverting to old jQuery version. Deploying to test now.

@frjo frjo force-pushed the maintenance/convert-jquery-to-vanilla branch from eefa536 to 988e4bb Compare December 13, 2024 20:49
@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team and removed Status: Tested - changes/discussion needed 🔨 labels Dec 13, 2024
@frjo frjo force-pushed the maintenance/convert-jquery-to-vanilla branch from 988e4bb to f193ecc Compare December 16, 2024 08:08
@wes-otf
Copy link
Contributor

wes-otf commented Dec 16, 2024

Looks like it's fixed to me on the test instance!

@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 16, 2024
@frjo frjo merged commit b966dfe into main Dec 16, 2024
7 checks passed
@frjo frjo deleted the maintenance/convert-jquery-to-vanilla branch March 11, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants