-
Notifications
You must be signed in to change notification settings - Fork 39
Convert jquery to vanilla, remove unused js, fix minor bugs #4273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will stop here, enough things to test as it is. Will be a part 2. |
|
Only issue I was seeing on test was with group fields not working - looked like they were revealed from the start. Heres the lab that I was testing with along with the form for that lab. Let me know if I'm missing something - nice changes overall though! excited to have less jquery |
0e3321b to
4195eec
Compare
|
@wes-otf You found a bug in form-group-toggle.js. I believe I have fixed it now, new version deploying to test now. |
|
@wes-otf There are more bugs, reverting to old jQuery version. Deploying to test now. |
eefa536 to
988e4bb
Compare
…t show status on mobile view for projects.
…ion all view where it is used.
988e4bb to
f193ecc
Compare
|
Looks like it's fixed to me on the test instance! |
Test Steps