Separate SOW & PAF form editing

[wes-otf]

Fixes #4204. Moves the SOW out into it's own form when editing. This also removes the user_has_updated_details attribute in favor of using a property for both the project form & SOW that checks the field_data on the respective form. This allows for tracking of the project form & SOW independently.

Also a few small aesthetic changes bundled in, like margin additions & hiding of submission attachments sidebar when there's none.

Screenshots

appearance when first creating a project

appearance after editing both forms

Test Steps

• When viewing the details of a project with both a Project Form & SOW, ensure that both appear under Project documents.
• Confirm that both can be edited, saved, and viewed on their own
• Confirm that when creating a project from a fund that has a Project Form & SOW, a todo list item is created for both

[frjo]

This is a good change, it was a bit of a hack having them merged in the first place.

Found some minor issues.

How will the SOW now fit in to the approval workflow?

[frjo]

Please use margin-inline-start instead.

[frjo]

ping

[frjo]

As a machine name we use "PAF" everywhere so I think it is best to stick with that.

I do not mind changing it to "PF" or "PROJECT_FORM" etc. but it should be done everywhere.

[frjo]

Ping

[frjo]

This class was removed in #4196.

[frjo]

Are not the "rich-text rich-text--answers" ok to use? We use them in most other places when we render streamfields.

[wes-otf]

all that left is getting these tests passing - a bit of a battle because my flag uses the project's form_data, but that won't get written unless a valid FormFieldBlock wrapped in a StreamValue is passed in the save method kwargs. it's giving me a hard time when I try to mock it

hypha/hypha/apply/projects/forms/project.py

Lines 137 to 143 in acdbea3

	def save(self, *args, **kwargs):
	self.instance.form_fields = kwargs.pop("paf_form_fields", {})
	self.instance.form_data = {
	field: self.cleaned_data[field]
	for field in self.instance.question_field_ids
	if field in self.cleaned_data
	}

[frjo]

@wes-otf How vital is the test? We could remove it.

[wes-otf]

@frjo Yeah that sounds good - I don't think it's vital as it'd really just be checking if form_data is an empty dict. I tossed it and added your suggestions

[wes-otf]

grabbed some final bugs but should be ready to be deployed to test now @frjo

[frjo]

@wes-otf When I download a SOW at http://apply.hypha.test:9001/apply/projects/4/sow/ no fields are added to the exports. I guess something changes regarding getting the fields?

When I test the main branch locally it seems to work as it should.

[wes-otf]

@frjo great catch! my logic was copy & pasted, checking self rather than project - also removed some mentions of the SOW in the PAF export.

[frjo]

Deploying the latest to test now.

[frjo]

Can confirm that the bug in sow exports are now fixed. Looks all good to me.

[wes-otf]

@frjo thanks for testing - I think it's ready to go then! I did more testing on my end too and didn't see anything