Enable group stream boxes when in draft and edit mode #4032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankduncan
force-pushed
the
4031-editing-group-texts
branch
from
4cbe72a to
85148d5
Compare
frjo
force-pushed
the
4031-editing-group-texts
branch
from
85148d5 to
7b6aca6
Compare
Member
|
@wes-otf Field groups only work when filling in an application form the first time. I do not remember why we did it this way. Do you/OTF see a reson for not having them active all the time (create/draft/edit)? |
Contributor
|
sorry, this slipped by me. but not that I'm aware of! If anything it would make make sense to me to have them all around |
frjo
force-pushed
the
4031-editing-group-texts
branch
from
7b6aca6 to
d1014dd
Compare
frjo
changed the title
frjo
force-pushed
the
4031-editing-group-texts
branch
from
3ab2b60 to
99eb330
Compare
frjo
force-pushed
the
4031-editing-group-texts
branch
from
99eb330 to
6f0bda8
Compare
frjo
added
Type: Enhancement
frjo
force-pushed
the
4031-editing-group-texts
branch
from
6f0bda8 to
c198800
Compare
frjo
added
Status: Needs testing
Member
|
@wes-otf This is now on test. |
frjo
force-pushed
the
4031-editing-group-texts
branch
from
c198800 to
25898af
Compare
Contributor
|
this works nice! I'll write up another issue but I think if the group fields are closed on submission the fields under them should be cleared - could make things weird for a reviewer if someone was still able to submit answers for a field that was supposed to be hidden but curious what you think @frjo |
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4031
They are disabled when editing a proposal in general, but in the case of a draft, the users sometimes need to be able to edit them in order to finish an application.
This fix may be incomplete, as it does not allow the group forms to have the full functionality of hiding the followup forms when "No" is selected, and showing them when "Yes" is selected.