chore: fix lint errors - remove unused catch parameter, apply prettier#26
Merged
chore: fix lint errors - remove unused catch parameter, apply prettier#26
Conversation
ESLint 9 requires Node.js 18.18+ or 20.9+ (uses structuredClone). Updated all CI jobs from Node 16.9 to Node 20.
Node's --test flag requires quoted glob patterns in npm scripts to work correctly across different shells (bash/sh/zsh).
Changed from test/**/*.test.js to test/*.test.js since all test files are in the root test directory. The recursive glob wasn't expanding correctly in CI bash environment.
Fastify tests were conflicting with Koa timeout test (both using port 3001). Changed fastify to use port 3002 to prevent EADDRINUSE errors in parallel test execution.
Changed from 'npm run coverage' to 'npm run test:coverage' to match the actual script name in package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small cleanup commit to fix linting issues that appeared after the security hardening PR.
Changes
errorparameter in JSON.parse catch block (ES2019+ allows omitting catch parameters)Verification
🤖 Generated with Claude Code