Skip to content

Type hints for iter_shard #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shahbaz-humeai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Type hints for iter_shard #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa68239
Type hints for iter_shard
shahbaz-humeai Feb 9, 2026
5f10219
logs
shahbaz-humeai Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wsds/ws_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ def _shard_n_samples(self, shard_name: (str, str)) -> int:
raise IndexError(f"Shard not found: {shard_name}")
return r[0]

def iter_shard(self, shard_name):
def iter_shard(self, shard_name: (str, str)):
dataset_path, shard_name = shard_name
if shard_name.endswith(".wsds"):
shard_name = shard_name[:-5]
Expand Down
4 changes: 4 additions & 0 deletions wsds/ws_sink.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ def write_batch(self, b, flush=False):
try:
record = pyarrow.RecordBatch.from_pylist(b, self._sink_schema if self._sink else None)
except Exception:
print(f"Batch data causing serialization error: {repr(b)}")
print(f"Schema: {self._sink_schema}")
print(f"Error while serializing: {repr(b)}")
raise
if self._sink is None:
Expand All @@ -73,6 +75,8 @@ def write_batch(self, b, flush=False):
self.batch_size *= 2
return
schema = record.schema.with_metadata({"batch_size": str(len(b))})
print(f"Initializing WSBatchedSink with batch size {self.batch_size} and schema:\n{schema}")
print(f"First batch data:\n{repr(b)}")
self._sink = pyarrow.RecordBatchFileWriter(
self.fname, schema, options=pyarrow.ipc.IpcWriteOptions(compression=self.compression)
)
Expand Down