Resolution to issues #74 and #129 #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added draft of scenarios modified adjust speed function for wave generation, more work needs to be done
…orresponding keypress(space-key for now)
… existing Hex.addblock instead of setting distFromHex = 0; Added unit tests for toggleDrop function
…rm to Qunit standards
…ordingly" This reverts commit f386eda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes fixes to 2 issues:
#74
The user can press the "T" to Toggle colourblind mode, which cycles through a set of colourblind friendly colours.
#129
The user can press the "Down" arrow key to slow down the progress of the game.
In addition, our own enhancement was proposed where the user can press the "Space" bar to immediately drop the closest block or chain of blocks immediately to the centre Hex.
Also, some Qunit tests were implemented for the new functionality in the following files
These test files can be deleted if unnecessary.