-
Notifications
You must be signed in to change notification settings - Fork 87
base64 itemstack item #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
new isItemStackOption
added base64 to item
oraxen 1.159.0 no more
no need to import all
useless space it's spose
wrong comment change
back to where it was
no need to import all eather
forget this change
fix oraxen version missmatch (#226)
|
sorry @BlitzOffline |
BlitzOffline
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/HelpChat/DeluxeMenus/actions/runs/16351498206/job/46200301651?pr=227
You forgot to import the classes you use. I'm not sure if this is something that happened after closing the PR, or what's going on.
BlitzOffline
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/HelpChat/DeluxeMenus/actions/runs/16351498206/job/46200301651?pr=227
You forgot to import the classes you use. I'm not sure if this is something that happened after closing the PR, or what's going on.
|
in files changed everything seems fine. i check for it |
change login event to join event (#223)
In MenuItem.java, you have not imported the following classes: Base64, ByteArrayInputStream, BukkitObjectInputStream, IllegalArgumentException, IOException and ClassNotFoundException. |
|
thanks god , thank you <3 |
BlitzOffline
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good now. However, considering what happened, I must ask if you've really tested this or not. If you haven't, please do!
|
sorry for what happened, i don't merge alot and i don't pull request alot, yes i test 'stack-' prefix in my conifgs for about a month and test it to put it manually and with placeholder, and if it was wrong it turn to stone |
Can you please send a few example of items you've tested? Thanks! |
|
here my example: |
|
Thanks, but I was more thinking about the base64 value itself. Would you be able to share one of those? |
|
sure here : |
|
Tested on 1.21.7. Works fine! |
|
thanks sir <3 |
HelpChat@0a1ec94 Added DeluxeMenusOpenMenuEvent and DeluxeMenusPreOpenMenuEvent (HelpChat#60) HelpChat@3230bdc fix oraxen version missmatch (HelpChat#226) HelpChat@797fd26 change login event to join event (HelpChat#223) HelpChat@54904dd base64 itemstack item (HelpChat#227) HelpChat@0e8cd8d Update Adventure API (HelpChat#237)
i made it so you can add "stack-" prefix so you can add any item with placeholder or base64 to make a full item (with displayname, lore, encahntments , ...)
this 'stack-' prefix allows to create an item with nothing set by default, and you can change it if you want
like from this:
to this:
or with custom name: