Skip to content

Conversation

@FakEEE14
Copy link
Contributor

i made it so you can add "stack-" prefix so you can add any item with placeholder or base64 to make a full item (with displayname, lore, encahntments , ...)

this 'stack-' prefix allows to create an item with nothing set by default, and you can change it if you want

like from this:

  'dailyreward':
    material: bell
    slot: 2
    display_name: '&e&lClick Me'
    lore:
      - '&7'
      - '&7Click to get it'
    item_flags:
      - HIDE_ENCHANTS
    enchantments:
      - DURABILITY;0

to this:

  'dailyreward':
    material: 'stack-base64'
    slot: 2
    item_flags:
      - HIDE_ENCHANTS

or with custom name:

  'dailyreward':
    material: 'stack-base64'
    display_name: '&e&lClick Me'
    slot: 2
    item_flags:
      - HIDE_ENCHANTS

@FakEEE14
Copy link
Contributor Author

FakEEE14 commented Jul 17, 2025

sorry @BlitzOffline
im new to this merging and i don't know how to merge, i did miss clicked something, my bad
should i open last request ?

Copy link
Member

@BlitzOffline BlitzOffline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/HelpChat/DeluxeMenus/actions/runs/16351498206/job/46200301651?pr=227

You forgot to import the classes you use. I'm not sure if this is something that happened after closing the PR, or what's going on.

Copy link
Member

@BlitzOffline BlitzOffline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/HelpChat/DeluxeMenus/actions/runs/16351498206/job/46200301651?pr=227

You forgot to import the classes you use. I'm not sure if this is something that happened after closing the PR, or what's going on.

@FakEEE14
Copy link
Contributor Author

in files changed everything seems fine. i check for it

change login event to join event (#223)
@BlitzOffline
Copy link
Member

in files changed everything seems fine. i check for it

In MenuItem.java, you have not imported the following classes: Base64, ByteArrayInputStream, BukkitObjectInputStream, IllegalArgumentException, IOException and ClassNotFoundException.

@FakEEE14
Copy link
Contributor Author

thanks god , thank you <3

Copy link
Member

@BlitzOffline BlitzOffline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good now. However, considering what happened, I must ask if you've really tested this or not. If you haven't, please do!

@FakEEE14
Copy link
Contributor Author

sorry for what happened, i don't merge alot and i don't pull request alot, yes i test 'stack-' prefix in my conifgs for about a month and test it to put it manually and with placeholder, and if it was wrong it turn to stone

@BlitzOffline
Copy link
Member

sorry for what happened, i don't merge alot and i don't pull request alot, yes i test 'stack-' prefix in my conifgs for about a month and test it to put it manually and with placeholder, and if it was wrong it turn to stone

Can you please send a few example of items you've tested? Thanks!

@FakEEE14
Copy link
Contributor Author

FakEEE14 commented Jul 17, 2025

here my example:

@BlitzOffline
Copy link
Member

Thanks, but I was more thinking about the base64 value itself. Would you be able to share one of those?

@FakEEE14
Copy link
Contributor Author

FakEEE14 commented Jul 17, 2025

sure here :
base64: rO0ABXNyABpvcmcuYnVra2l0LnV0aWwuaW8uV3JhcHBlcvJQR+zxEm8FAgABTAADbWFwdAAPTGphdmEvdXRpbC9NYXA7eHBzcgA1Y29tLmdvb2dsZS5jb21tb24uY29sbGVjdC5JbW11dGFibGVNYXAkU2VyaWFsaXplZEZvcm0AAAAAAAAAAAIAAkwABGtleXN0ABJMamF2YS9sYW5nL09iamVjdDtMAAZ2YWx1ZXNxAH4ABHhwdXIAE1tMamF2YS5sYW5nLk9iamVjdDuQzlifEHMpbAIAAHhwAAAABHQAAj09dAABdnQABHR5cGV0AARtZXRhdXEAfgAGAAAABHQAHm9yZy5idWtraXQuaW52ZW50b3J5Lkl0ZW1TdGFja3NyABFqYXZhLmxhbmcuSW50ZWdlchLioKT3gYc4AgABSQAFdmFsdWV4cgAQamF2YS5sYW5nLk51bWJlcoaslR0LlOCLAgAAeHAAAA/ydAANRElBTU9ORF9TV09SRHNxAH4AAHNxAH4AA3VxAH4ABgAAAAVxAH4ACHQACW1ldGEtdHlwZXQADGRpc3BsYXktbmFtZXQABGxvcmV0AAhlbmNoYW50c3VxAH4ABgAAAAV0AAhJdGVtTWV0YXQAClVOU1BFQ0lGSUN0AB17InRleHQiOiIiLCJleHRyYSI6WyJzaGFycCJdfXNyABNqYXZhLnV0aWwuQXJyYXlMaXN0eIHSHZnHYZ0DAAFJAARzaXpleHAAAAADdwQAAAADdAAbeyJ0ZXh0IjoiIiwiZXh0cmEiOlsiMSAxIl19dAAbeyJ0ZXh0IjoiIiwiZXh0cmEiOlsiMiAyIl19dAAbeyJ0ZXh0IjoiIiwiZXh0cmEiOlsiMyAzIl19eHNxAH4AA3VxAH4ABgAAAAJ0ABVtaW5lY3JhZnQ6cmVzcGlyYXRpb250ABNtaW5lY3JhZnQ6c2hhcnBuZXNzdXEAfgAGAAAAAnNxAH4ADgAAAAtzcQB+AA4AAABa
if goes wrong it's turn to stone

@BlitzOffline
Copy link
Member

Tested on 1.21.7. Works fine!

@BlitzOffline BlitzOffline merged commit 54904dd into HelpChat:main Jul 17, 2025
2 checks passed
@FakEEE14
Copy link
Contributor Author

thanks sir <3

Euphillya added a commit to Euphillya/DeluxeMenus-Folia that referenced this pull request Aug 7, 2025
HelpChat@0a1ec94 Added DeluxeMenusOpenMenuEvent and DeluxeMenusPreOpenMenuEvent (HelpChat#60)
HelpChat@3230bdc fix oraxen version missmatch (HelpChat#226)
HelpChat@797fd26 change login event to join event (HelpChat#223)
HelpChat@54904dd base64 itemstack item  (HelpChat#227)
HelpChat@0e8cd8d Update Adventure API (HelpChat#237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants