Skip to content

Fix light_level being overwritten for LIGHT item.#200

Merged
Kqliber merged 1 commit intomainfrom
issue/197
May 23, 2025
Merged

Fix light_level being overwritten for LIGHT item.#200
Kqliber merged 1 commit intomainfrom
issue/197

Conversation

@BlitzOffline
Copy link
Member

Fix light_level being overwritten.

image
image

Closes #197

Tested with: Paper version 1.21.4-230-ver/1.21.4@af71568 (2025-05-11T20:55:55Z) (Implementing API version 1.21.4-R0.1-SNAPSHOT)
Tested ITEM_FLAGS to make sure they still apply as well.

@NoltoxGit
Copy link

Hey,
What is lore_append_mode? 👀

@BlitzOffline
Copy link
Member Author

Hey, What is lore_append_mode? 👀

It is an option that has 4 values: OVERRIDE, BOTTOM, TOP, IGNORE. It can be used in combination with the lore option and item hooks such as MMOItems.

The item hooks sometimes return custom lore as well, not just materials and model data. So based on the lore append mode value, the following will happen:

OVERRIDE - it will replace the lore returned by the item hook with the one specified in lore.
BOTTOM - it will append the lore specified in lore at the bottom of the one returned by the item hook.
TOP - it will append the lore specified in lore above the one returned by the item hook.
IGNORE - it will ignore the lore specified in lore and only use the one returned by the item hook.

Default value is OVERRIDE.

@NoltoxGit
Copy link

Hey, What is lore_append_mode? 👀

It is an option that has 4 values: OVERRIDE, BOTTOM, TOP, IGNORE. It can be used in combination with the lore option and item hooks such as MMOItems.

The item hooks sometimes return custom lore as well, not just materials and model data. So based on the lore append mode value, the following will happen:

OVERRIDE - it will replace the lore returned by the item hook with the one specified in lore. BOTTOM - it will append the lore specified in lore at the bottom of the one returned by the item hook. TOP - it will append the lore specified in lore above the one returned by the item hook. IGNORE - it will ignore the lore specified in lore and only use the one returned by the item hook.

Default value is OVERRIDE.

Is this available in the latest devbuild (#200)?

@BlitzOffline
Copy link
Member Author

Yes. It is available since one of the 18X builds I think.

@NoltoxGit
Copy link

Yes. It is available since one of the 18X builds I think.

Perfect!
Because I'd never seen that in the documentation, that's why! x)

@BlitzOffline
Copy link
Member Author

Yeah. We are not very consistent with our documentation. A few features from the dev builds are documented but most are not and a few other are even wrong.

We usually get the documentation up to date before a Spigot release.

@Kqliber Kqliber merged commit a465d9a into main May 23, 2025
2 checks passed
@Kqliber Kqliber deleted the issue/197 branch May 23, 2025 18:31
Euphillya added a commit to Euphillya/DeluxeMenus-Folia that referenced this pull request Jul 11, 2025
HelpChat@a465d9a Fix light_level being overwritten for LIGHT item. (HelpChat#200)
HelpChat@41b2476 Fix MMO-Items not working when item id contains colon(s). (HelpChat#194)
HelpChat@87141c0 Improve metadata / PDC usage (HelpChat#183)
HelpChat@bc699b8 improve bstats (HelpChat#202)
HelpChat@a20c30d update adventure for 1.21.5 (HelpChat#201)
HelpChat@f048028 Fix exception that occurs when trying to add metadata. (HelpChat#205)
HelpChat@08fbb34 fix command event action (HelpChat#206)
HelpChat@d512986 Added support for the new CustomModelDataComponent (HelpChat#195)
HelpChat@4f05d70 Finally, a release (HelpChat#207)
HelpChat@9fc732f Moved to 1.14.2-dev and added CODE_OF_CONDUCT.md & CONTRIBUTING.md files (HelpChat#212)
HelpChat@6775b7f Add Menu Refresh Task and Command for Complete Menu Rebuilding (HelpChat#189)
HelpChat@4ae3bf6 fix README.md link (HelpChat#214)
HelpChat@d884d8d Add gitbook badge (HelpChat#215)
HelpChat@944a113 Add [log] Action to Output Console Messages for Debugging/Testing, Closes HelpChat#199 (HelpChat#208)
HelpChat@94d6632 fix for textures not showing on player name heads (HelpChat#213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Unconfirmed] Light level is broken in the latest dev build.

3 participants