Access to Sound#valueOf method through Reflection to avoid java.lang IncompatibleClassChangeError when using versions prior to 1.21.3#158
Merged
Kqliber merged 2 commits intoHelpChat:mainfrom Jan 14, 2025
MemencioPerez:main
Merged
Access to Sound#valueOf method through Reflection to avoid java.lang IncompatibleClassChangeError when using versions prior to 1.21.3#158Kqliber merged 2 commits intoHelpChat:mainfrom MemencioPerez:main
Kqliber merged 2 commits intoHelpChat:mainfrom
MemencioPerez:main
Conversation
…IncompatibleClassChangeError when using versions prior to 1.21.3
Collaborator
|
I think it'd just be better if we finally switched to the method with a String parameter for the sound, that way custom sounds can finally be used. https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/entity/Player.html#playSound(org.bukkit.Location,java.lang.String,float,float) |
BlitzOffline
requested changes
Jan 12, 2025
src/main/java/com/extendedclip/deluxemenus/utils/SoundUtils.java
Outdated
Show resolved
Hide resolved
…ttempting to access the Sound#valueOf method through Reflection
BlitzOffline
approved these changes
Jan 14, 2025
Kqliber
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to fix #157