feat: publish file events for FormRs #791
Merged
+414
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Form-R S3 file is updated, the NDW exporter broadcasts an update event which `tis-trainee-actions` and `tis-trainee-notifications` are dependant on. This was a quick hack since NDW exporter was already listening for S3 events and pulling the form data from the JSON file. To allow the forms service to refresh NDW FormRs without triggering actions/notifications updates the functionality must be moved out of the NDW exporter. Eventually the actions and notifications services will be updated to work with the existing form update events broadcast by the forms service. But this resolves the issue temporarily, migration to the new events will be done in a more controlled way rather than as a dependency as part of live defect work. TIS21-8243 TIS21-8244
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Form-R S3 file is updated, the NDW exporter broadcasts an update event which
tis-trainee-actionsandtis-trainee-notificationsare dependant on. This was a quick hack since NDW exporter was already listening for S3 events and pulling the form data from the JSON file.To allow the forms service to refresh NDW FormRs without triggering actions/notifications updates the functionality must be moved out of the NDW exporter.
Eventually the actions and notifications services will be updated to work with the existing form update events broadcast by the forms service. But this resolves the issue temporarily, migration to the new events will be done in a more controlled way rather than as a dependency as part of live defect work.
TIS21-8243
TIS21-8244