refactor: LTFT PDF #786
Open
refactor: LTFT PDF #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorisWongNHS
force-pushed
the
refactor/ltftPdf
branch
2 times, most recently
from
8ddd5f8 to
7778d15
Compare
john12321
reviewed
Jan 27, 2026
DorisWongNHS
force-pushed
the
refactor/ltftPdf
branch
2 times, most recently
from
cb4772a to
06916ac
Compare
john12321
reviewed
Jan 28, 2026
Contributor
john12321
left a comment
john12321
left a comment
There was a problem hiding this comment.
Logic LGTM @DorisWongNHS (FWIW 😂)
DorisWongNHS
force-pushed
the
refactor/ltftPdf
branch
from
06916ac to
0e0a3c6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample PDF:
ltft_75da045d-f6e5-4614-a1fa-a7a1ce661f6a (10).pdf
isShortNoticefield is added to the LtftFormDto. The logic is located in the Mapper (align with the way for LtftAdminSummaryDto):If the application is DRAFT or UNSUBMITTED, calculate short notice with current date; For applications in other states, calculate with submitted date.
TIS21-8207
TIS21-8208