Conversation
…the next available loopback address and parameterize config. And don't print super noisy stdout that obscures the real error
kriszyp
commented
Feb 18, 2026
| setTimeout(() => { | ||
| captureProfile(PROFILE_PERIOD); | ||
| }, PROFILE_PERIOD).unref(); | ||
| if (PROFILE_PERIOD > 0) { |
Member
Author
There was a problem hiding this comment.
This sure caused a lot of bizarre problems until I figured it out.
DavidCockerill
approved these changes
Feb 18, 2026
Member
DavidCockerill
left a comment
DavidCockerill
left a comment
There was a problem hiding this comment.
I'm thinking I might add more console logging to HarperLifecycle, mainly around setting up and validating the loopback. It can take a while, and without visibility it sometimes appears to be stalled.
Member
Author
FWIW, most of my problems with getting correct loopback addresses had to do with orphaned processes, which the process killing should help with. However, killing a test could still result in orphaned processes, I think. |
cap10morgan
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stacks on top of #150 (it doesn't target it, since this has main merged into it), with a bunch of fixes and enhancements for more reliable and flexible integration tests.