-
Notifications
You must be signed in to change notification settings - Fork 19
Diana Chukhrai #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
📝 HackYourFuture auto gradeAssignment Score: 52 / 100 ✅Status: ✅ Passed Test Details |
mnvacym
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Diana, great job on your first assignment.
There are minor improvements needed for the first task. I’ve added comments with suggestions; please let me know if anything is unclear.
For the second task, it looks like there is an issue with Top Languages Card and Streak Stats Card on your GitHub profile.
Overall, you did a good job. Best of luck on your journey at Hack Your Future.
| mkdir src | ||
| mkdir src/database | ||
| mkdir src/profile | ||
| touch resources/family_picture.jpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file name needs to be family picture.jpg (with a space). So you can make use of quotes (").
| echo "Welcome to my project" > README.md | ||
| rm -r src/profile | ||
| rm resources/family_picture.jpg | ||
| echo "Setup javascript…" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After removing family picture.jpg file, you need to create the second commit with a descriptive message:
11. Create a second commit with the new changes. Provide a descriptive message.
| echo "console.log('JavaScript works!');" > src/program.js | ||
| node src/program.js | ||
| git add . | ||
| git commit -m "third commit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message needs to be descriptive:
18. Create a third commit with the last changes. Provide a descriptive message.
| @@ -0,0 +1,2 @@ | |||
| # Creating project... | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not needed.
| @@ -1 +1,26 @@ | |||
| # Write your code here | |||
| # Creating project... | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually it is a good practice to include #!/bin/bash or #!/usr/bin/env bash line at the beginning of a shell script file.
| touch resources/icon.png | ||
| touch resources/logo.png | ||
| touch src/program.java | ||
| echo "Setup project..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After creating files and folders, you need to create the first commit wit the message "initial commit":
5. Commit the changes to git with the message “initial commit".
No description provided.