-
Notifications
You must be signed in to change notification settings - Fork 19
Baraah A. #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Baraah A. #16
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mnvacym
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Baraah, good job on your first assignment.
The steps you followed are correct, but the content in the setup.sh file is incorrect. Your file needs to be an executable shell script. Essentially, when you run the command sh setup.sh, it should execute all those steps:
The script should work from any folder and run on any computer with Bash shell and Node.js installed.
You might want to revisit the Basic Scripting section.
For the second task, it appears there is an issue with the Top Languages Card and Streak Stats Card on your GitHub profile.
As per the Submission Guideline, the PR title should be your name with the first letter of the last name. Please refer to step 6:
The title of the PR should be your name with the first letter of the last name
Overall, you did a good job, but you need to update your setup.sh file so it can be executed. Best of luck on your journey at Hack Your Future.
task-1/setup.sh
Outdated
| barbari@baraahs-MBP-2 project % rm -r src/profile | ||
| barbari@baraahs-MBP-2 project % rm resources/"family picture.jpg" | ||
| barbari@baraahs-MBP-2 project % git add . | ||
| barbari@baraahs-MBP-2 project % git commit -m "Updated" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message needs to be descriptive:
11. Create a second commit with the new changes. Provide a descriptive message.
task-1/setup.sh
Outdated
| barbari@baraahs-MBP-2 project % node src/program.js | ||
| javascript works! | ||
| barbari@baraahs-MBP-2 project % git add . | ||
| barbari@baraahs-MBP-2 project % git commit -m "changed program to JScript and added console.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice descriptive commit message.
task-1/setup.sh
Outdated
| Movies file2.txt project | ||
| Music flask web app project_flask.zip | ||
| Notebook python hello.js user | ||
| barbari@baraahs-MBP-2 project % cd ~/project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As of this point you're already in project, so no need for cd ~/project
| @@ -1 +1,85 @@ | |||
| # Write your code here | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually it is a good practice to include #!/bin/bash or #!/usr/bin/env bash line at the beginning of a shell script file.
task-1/setup.sh
Outdated
| create mode 100644 resources/logo.png | ||
| create mode 100644 settings.conf | ||
| create mode 100644 src/program.java | ||
| barbari@baraahs-MBP-2 project % echo "Setup project.." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add a command for waiting for 3 seconds:
6. Wait for 3 seconds
task-1/setup.sh
Outdated
| [main 8c4b760] Updated | ||
| 2 files changed, 1 insertion(+) | ||
| delete mode 100644 resources/family picture.jpg | ||
| barbari@baraahs-MBP-2 project % ls resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before listing contents of resources folder, you need to add a command for waiting for 3 seconds:
12. Wait for 3 seconds
|
Okk I will try to fix it .. thank you
…On Sun, Jan 18, 2026 at 8:53 PM Ammar ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hi Baraah, good job on your first assignment.
The steps you followed are correct, but the content in the setup.sh file
is incorrect. Your file needs to be an executable shell script.
Essentially, when you run the command sh setup.sh, it should execute all
those steps:
*The script should work from any folder and run on any computer with Bash
shell and Node.js installed.*
You might want to revisit the Basic Scripting
<https://hub.hackyourfuture.nl/Basic-scripting-2ab50f64ffc980dabba2efa706b946f0>
section.
For the second task, it appears there is an issue with the Top Languages
Card and Streak Stats Card on your GitHub profile.
As per the Submission Guideline
<https://hub.hackyourfuture.nl/assignment-submission-guide>, the PR title
should be your name with the first letter of the last name. Please refer to
step 6:
*The title of the PR should be your name with the first letter of the last
name*
Overall, you did a good job, but you need to update your setup.sh file so
it can be executed. Best of luck on your journey at Hack Your Future.
------------------------------
In task-1/setup.sh
<#16 (comment)>
:
> ***@***.*** project % git commit -m "initial commit"
+[main (root-commit) b69e699] initial commit
+ 6 files changed, 0 insertions(+), 0 deletions(-)
+ create mode 100644 README.md
+ create mode 100644 resources/family picture.jpg
+ create mode 100644 resources/icon.png
+ create mode 100644 resources/logo.png
+ create mode 100644 settings.conf
+ create mode 100644 src/program.java
***@***.*** project % echo "Setup project.."
+Setup project..
***@***.*** project % echo "Welcome to my project" > README.md
***@***.*** project % rm -r src/profile
***@***.*** project % rm resources/"family picture.jpg"
***@***.*** project % git add .
***@***.*** project % git commit -m "Updated"
The commit message needs to be descriptive:
*11. Create a second commit with the new changes. Provide a descriptive
message.*
------------------------------
In task-1/setup.sh
<#16 (comment)>
:
> ***@***.*** project % rm resources/"family picture.jpg"
***@***.*** project % git add .
***@***.*** project % git commit -m "Updated"
+[main 8c4b760] Updated
+ 2 files changed, 1 insertion(+)
+ delete mode 100644 resources/family picture.jpg
***@***.*** project % ls resources
+icon.png logo.png
***@***.*** project % echo "Setup javascript.."
+Setup javascript..
***@***.*** project % mv src/program.java src/program.js
***@***.*** project % echo "console.log('javascript works!');" > src/program.js
***@***.*** project % node src/program.js
+javascript works!
***@***.*** project % git add .
***@***.*** project % git commit -m "changed program to JScript and added console.log"
Nice descriptive commit message.
------------------------------
In task-1/setup.sh
<#16 (comment)>
:
> +[main e96f04b] changed program to JScript and added console.log
+ 2 files changed, 1 insertion(+)
+ delete mode 100644 src/program.java
+ create mode 100644 src/program.js
***@***.*** project % ls ~
+Applications Pictures iCloud Drive (Archive)
+CAPSTONE1 Public index
+Desktop PycharmProjects library_system
+Documents app2 libraryweb2
+Downloads eclipse myWebLibrary
+Library eclipse-workspace myWebLibrary.zip
+LibraryWebProgramming file1.txt myapp
+Movies file2.txt project
+Music flask web app project_flask.zip
+Notebook python hello.js user
***@***.*** project % cd ~/project
As of this point you're already in project, so no need for cd ~/project
------------------------------
In task-1/setup.sh
<#16 (comment)>
:
> \ No newline at end of file
+
Usually it is a good practice to include #!/bin/bash or #!/usr/bin/env
bash line at the beginning of a shell script file.
------------------------------
In task-1/setup.sh
<#16 (comment)>
:
> +database profile program.java
+
+./src/database:
+
+./src/profile:
***@***.*** project % git add .
***@***.*** project % git commit -m "initial commit"
+[main (root-commit) b69e699] initial commit
+ 6 files changed, 0 insertions(+), 0 deletions(-)
+ create mode 100644 README.md
+ create mode 100644 resources/family picture.jpg
+ create mode 100644 resources/icon.png
+ create mode 100644 resources/logo.png
+ create mode 100644 settings.conf
+ create mode 100644 src/program.java
***@***.*** project % echo "Setup project.."
You need to add a command for waiting for 3 seconds:
*6. Wait for 3 seconds*
------------------------------
In task-1/setup.sh
<#16 (comment)>
:
> + create mode 100644 resources/family picture.jpg
+ create mode 100644 resources/icon.png
+ create mode 100644 resources/logo.png
+ create mode 100644 settings.conf
+ create mode 100644 src/program.java
***@***.*** project % echo "Setup project.."
+Setup project..
***@***.*** project % echo "Welcome to my project" > README.md
***@***.*** project % rm -r src/profile
***@***.*** project % rm resources/"family picture.jpg"
***@***.*** project % git add .
***@***.*** project % git commit -m "Updated"
+[main 8c4b760] Updated
+ 2 files changed, 1 insertion(+)
+ delete mode 100644 resources/family picture.jpg
***@***.*** project % ls resources
Before listing contents of resources folder, you need to add a command for
waiting for 3 seconds:
*12. Wait for 3 seconds*
—
Reply to this email directly, view it on GitHub
<#16 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B43F3KECGABYB4Z2DZHZ7ZL4HPQDXAVCNFSM6AAAAACR5N2NLGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNZVG4YDQNZYGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
📝 HackYourFuture auto gradeAssignment Score: 85 / 100 ✅Status: ✅ Passed Test Details |
No description provided.