Ivan w3 react #25
Open
Ivan w3 react #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crevulus
reviewed
Jan 18, 2026
crevulus
left a comment
crevulus
left a comment
There was a problem hiding this comment.
What a great app! Simple and elegant styling; well done.
I've left some comments for you to review. You might also want to check that you are exporting the SVGs correctly. They are not rendering in your deployed site.
| @@ -0,0 +1,2 @@ | |||
| export const normalizeCategory = (value: string): string => | |||
There was a problem hiding this comment.
Clean up files you no longer need. Unused files (otherwise known as "deadwood") can slow down your application if not dealt with.
| ); | ||
|
|
||
| // Показываем состояние загрузки === Show loading state | ||
| if (loading) { |
| @@ -0,0 +1,29 @@ | |||
| /* src/pages/HomePage.css */ | |||
| .home-page { | |||
There was a problem hiding this comment.
You have some home page styles in here and some in index.css, when you have some component styles in index.css and some coupled with the component in /components. Keep your styling files consistent so employers can see you're keeping directory orderliness in mind.
| const [loading, setLoading] = useState(true); | ||
| const [error, setError] = useState<string | null>(null); | ||
|
|
||
| useEffect(() => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file README LINK.md - with the link
Just in case, I'll duplicate the link here
https://69673818c8ef27f4a13f91f1--celebrated-tapioca-1791f9.netlify.app/