majd jadalhaq Week3 REACT #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JalalHabeeb
reviewed
Jan 13, 2026
JalalHabeeb
left a comment
JalalHabeeb
left a comment
There was a problem hiding this comment.
Nice work with hooks and a custom hook.
only one comment 👍🏽
|
|
||
| const FavoritesContext = createContext(); | ||
|
|
||
| export const FavoritesProvider = ({ children }) => { |
There was a problem hiding this comment.
One file should only export one React component. It's better to separate the exports in two files
Author
There was a problem hiding this comment.
thank you for the feed back i just fixed it and pushed the commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ecommerce-w3-react.netlify.app/