DARYNA_TKACHENKO-w1-browsers #3
Conversation
acadavid
left a comment
acadavid
left a comment
There was a problem hiding this comment.
@dashaaaa21 Great job! Almost there. Some minor adjustments to make.
| -----------------------------------------------------------------------------*/ | ||
| //cspell: enable | ||
|
|
||
| function createBookList(books) { |
| const currentTime = hours + ':' + minutes + ':' + seconds; | ||
| const timeElement = document.getElementById('time'); | ||
| if (timeElement) { | ||
| timeElement.textContent = currentTime; |
There was a problem hiding this comment.
I see the value displayed in the console but not on the page itself, what could be going on?
There was a problem hiding this comment.
Thank you very much, I have already changed this assignment
| -----------------------------------------------------------------------------*/ | ||
| function catWalk() { | ||
| // TODO complete this function | ||
| const img = document.querySelector('img'); |
There was a problem hiding this comment.
I think the cat needs to stop in the middle, dance, and then continue walking. Want to give it another try?
There was a problem hiding this comment.
Thank you very much, I have already changed this assignment
acadavid
left a comment
acadavid
left a comment
There was a problem hiding this comment.
Looks good! I left a final suggestion for you to simplify the code and get rid of an unnecessary method. Would you mind changing that? But I'll approve your homework already 👍
| if (img.complete && img.naturalWidth > 0) { | ||
| timer = setInterval(step, 50); | ||
| } else { | ||
| img.addEventListener('load', () => { |
There was a problem hiding this comment.
I see that you're using load here, but you already have window.addEventListener('DOMContentLoaded', catWalk);. DOMContentLoaded awaits for the DOM elements (p, spans, etc) to be loaded, but not for the rest of the elements to be loaded like images. load does wait for them as I see you're trying to do here, also by checkingimg.complete.
Can you simplify the code to avoid the startWhenReady() method? You can modify the eventListener for catWalk :)
There was a problem hiding this comment.
Thank you very much, I’ve already changed exercise 5
2 participants
No description provided.