Skip to content

Revert validator #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahjyrkia merged 3 commits into from
Oct 28, 2025
Merged

Revert validator #126

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85b8329
fixed package.json
ahjyrkia Oct 28, 2025
5b939d8
types added for validator
ahjyrkia Oct 28, 2025
c964e69
revert validator
ahjyrkia Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/auth/groupAssignments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import validator from 'validator'
import {
IUserInfo,
requestGroups,
Expand All @@ -14,10 +13,6 @@ export async function assignUserToGroups(userInfo: IUserInfo): Promise<IUserInfo
return userInfo
}

if (!validator.isEmail(userInfo.email)) {
return userInfo
}

const settings = await getSettings()
const domainGroups = settings.domain_groups
const autoDomainGroups = settings.auto_domain_groups
Expand All @@ -36,11 +31,7 @@ export async function assignUserToGroups(userInfo: IUserInfo): Promise<IUserInfo
)

const sessionGroups = userInfo.groups
const parsedDomains = userInfo.email.split('@')
const emailDomain = parsedDomains[parsedDomains.length - 1]?.toLowerCase()
const emailDomainGroups = assignGroups.filter(
(dg) => emailDomain === dg.domain.toLowerCase()
)
const emailDomainGroups = assignGroups.filter((dg) => userInfo.email.endsWith(dg.domain))
const groupAssignments = uniq(flatten(emailDomainGroups.map(({ groups }) => groups)))
const assignToGroups = difference(groupAssignments, sessionGroups)

Expand Down