Skip to content

error response added #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahjyrkia merged 2 commits into from
Aug 27, 2025
Merged

error response added #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2f6957
error response added
ahjyrkia Aug 4, 2025
cc67fbe
node bump
ahjyrkia Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:12-alpine
FROM node:14-alpine

RUN apk --no-cache add curl

Expand Down
9 changes: 4 additions & 5 deletions src/creators/createAreaJourneysResponse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
} from '../types/generated/schema-types'
import { CachedFetcher } from '../types/CachedFetcher'
import { cacheFetch } from '../cache'
import { ForbiddenError } from 'apollo-server-errors'
import { groupBy, map } from 'lodash'
import { createAreaJourneyObject } from '../objects/createAreaJourneyObject'
import { createBBoxString } from '../utils/createBBoxString'
Expand Down Expand Up @@ -47,7 +48,9 @@ export const createAreaJourneysResponse = async (
(events: Vehicles[]) => createAreaJourneyObject(events)
)
}

if (speedFilter && !user) {
throw new ForbiddenError('Authentication required. Please login.')
}
// Cache for when a link containing an area query is shared.
const cacheKey = `area_journeys_${createBBoxString(bbox)}_${minTime}_${maxTime}_${date}_${
!!user && unsignedEvents ? 'unsigned' : ''
Expand All @@ -58,10 +61,6 @@ export const createAreaJourneysResponse = async (
return []
}

if (speedFilter && !user) {
return []
}

let hslGroup: boolean = false
if (user) {
if (requireUser(user, 'HSL')) {
Expand Down
Loading