Skip to content

Add immediate and final sampling to ProcessMonitor #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graeme-a-stewart merged 5 commits into from
Feb 24, 2026
Merged

Add immediate and final sampling to ProcessMonitor #300

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
90b0dfc
Add immediate and final sampling
Feb 18, 2026
2c56026
Fix sampling logic for short-lived processes
Feb 19, 2026
bae45c5
Ensure at least one sampling iteration for short-lived processes
Feb 19, 2026
4e708aa
Remove redundant first assignment and condition check
Siddhant2306 Feb 24, 2026
6d8689c
Remove unused iteration variable
Siddhant2306 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions package/src/prmon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ int ProcessMonitor(const pid_t mpid, const std::string filename,
}
}

int iteration = 0;
time_t lastIteration = time(0) - interval;
time_t currentTime;

Expand Down Expand Up @@ -137,13 +136,15 @@ int ProcessMonitor(const pid_t mpid, const std::string filename,
bool wroteFile = false;
std::vector<pid_t> cpids{};
int return_code = 0;

bool first = true;
// Scope of 'monitors' ensures safety of bare pointer here
auto wallclock_monitor_p = static_cast<wallmon*>(monitors["wallmon"].get());
while (kill(mpid, 0) == 0 && prmon::sigusr1 == false) {
if (time(0) - lastIteration > interval) {
iteration++;
if (first || time(0) - lastIteration > interval){
// Reset lastIteration
lastIteration = time(0);
first = false;

if (modern_kernel)
cpids = prmon::offspring_pids(mpid);
Expand Down Expand Up @@ -195,7 +196,7 @@ int ProcessMonitor(const pid_t mpid, const std::string filename,
}
}
}

// Write JSON realtime summary to a temporary file
std::ofstream json_out(tmp_json_file.str());
json_out << std::setw(2) << json_summary << std::endl;
Expand Down Expand Up @@ -224,7 +225,7 @@ int ProcessMonitor(const pid_t mpid, const std::string filename,
file.close();

// Cleanup snapshot file
if (remove(json_snapshot_file.str().c_str()) != 0 && iteration > 0)
if (remove(json_snapshot_file.str().c_str()) != 0 && errno != ENOENT)
perror("remove fails");

// Write final JSON summary file
Expand Down