Skip to content

取消了下载界面硬控用户的功能,添加了下载界面的下载列表的bug(doge#5952

Closed
o-pqw wants to merge 4 commits intoHMCL-dev:mainfrom
o-pqw:main
Closed

取消了下载界面硬控用户的功能,添加了下载界面的下载列表的bug(doge#5952
o-pqw wants to merge 4 commits intoHMCL-dev:mainfrom
o-pqw:main

Conversation

@o-pqw
Copy link
Copy Markdown

@o-pqw o-pqw commented Apr 12, 2026

如题,另外org.jackhuang.hmcl.task.AsyncTaskExecutor的canel变更了一下

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.0-bin.zip
distributionUrl=https\://mirrors.cloud.tencent.com/gradle/gradle-9.4.0-bin.zip
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要更改这个

@@ -0,0 +1,38 @@
/* 下载任务列表单元格 */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议不要单独创立新的css和中文注释


@Override
public void onPageHidden() {
//打开页面时运行
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


tab.select(newGameTab);

//这一堆规划了侧边栏的哪个按钮在哪个栏目
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议不要用中文

@CiiLu
Copy link
Copy Markdown
Contributor

CiiLu commented Apr 12, 2026

HMCL 会硬控你的 Task 基本上都是没有做避免并发冲突的,这样简单粗暴地后台运行会带来很多问题。

此外,目前已有一个后台下载 PR #5435
还有不要在 main 分支打开 PR。

pane.setExecutor(executor);
dialog(pane);
return pane;
// TaskExecutorDialogPane pane = new TaskExecutorDialogPane(onCancel);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是在做什么?

import org.jackhuang.hmcl.task.TaskExecutor;
import org.jackhuang.hmcl.ui.versions.DownloadTaskList;

public class DifferentDownloadTask2OneTask{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个类和里面的方法都是什么见鬼的命名?为什么还在 System.out.println

@Glavo
Copy link
Copy Markdown
Member

Glavo commented Apr 12, 2026

请不要拿 AI 生成包含一大堆问题的代码,自己看都不看就交上来。

我们不反对使用 AI 辅助,但用 AI 生成后请自己认真审查后再打开 PR,而不是用这样乱七八糟的东西浪费其他人的时间。

@Glavo Glavo closed this Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants