Closed
Conversation
Wulian233
suggested changes
Apr 12, 2026
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.0-bin.zip | ||
| distributionUrl=https\://mirrors.cloud.tencent.com/gradle/gradle-9.4.0-bin.zip |
| @@ -0,0 +1,38 @@ | |||
| /* 下载任务列表单元格 */ | |||
|
|
||
| @Override | ||
| public void onPageHidden() { | ||
| //打开页面时运行 |
|
|
||
| tab.select(newGameTab); | ||
|
|
||
| //这一堆规划了侧边栏的哪个按钮在哪个栏目 |
Contributor
|
HMCL 会硬控你的 Task 基本上都是没有做避免并发冲突的,这样简单粗暴地后台运行会带来很多问题。 此外,目前已有一个后台下载 PR #5435 |
Glavo
reviewed
Apr 12, 2026
| pane.setExecutor(executor); | ||
| dialog(pane); | ||
| return pane; | ||
| // TaskExecutorDialogPane pane = new TaskExecutorDialogPane(onCancel); |
| import org.jackhuang.hmcl.task.TaskExecutor; | ||
| import org.jackhuang.hmcl.ui.versions.DownloadTaskList; | ||
|
|
||
| public class DifferentDownloadTask2OneTask{ |
Member
There was a problem hiding this comment.
这个类和里面的方法都是什么见鬼的命名?为什么还在 System.out.println?
Member
|
请不要拿 AI 生成包含一大堆问题的代码,自己看都不看就交上来。 我们不反对使用 AI 辅助,但用 AI 生成后请自己认真审查后再打开 PR,而不是用这样乱七八糟的东西浪费其他人的时间。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
如题,另外org.jackhuang.hmcl.task.AsyncTaskExecutor的canel变更了一下