chore: remove unused local badge CSS after StatusBadge migration #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These badge styles are now defined in the shared StatusBadge component using :global() selectors. This cleanup removes 50 lines of duplicate CSS. - assets/+page.svelte: Remove badge-draft, badge-active, badge-disposed, badge-sold - contacts/+page.svelte: Remove badge-customer, badge-supplier, badge-both - employees/+page.svelte: Remove badge-fulltime, badge-parttime, badge-contract (keep badge-active/badge-inactive for boolean is_active display) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Complete CSS cleanup after StatusBadge migration. This removes 205 additional lines of duplicate badge CSS from 10 more page components. Files cleaned: - invoices/+page.svelte: 30 lines (draft, sent, partial, paid, overdue, voided) - quotes/+page.svelte: 30 lines (draft, sent, accepted, rejected, expired, converted) - orders/+page.svelte: 30 lines (pending, confirmed, processing, shipped, delivered, cancelled) - payroll/+page.svelte: 25 lines (draft, calculated, approved, paid, declared) - employees/absences/+page.svelte: 20 lines (pending, approved, rejected, cancelled) - tsd/+page.svelte: 20 lines (draft, submitted, accepted, rejected) - tax/+page.svelte: 15 lines (draft, submitted, accepted) - settings/email/+page.svelte: 15 lines (success, danger, muted) - payments/+page.svelte: 10 lines (received, made) - payments/cash/+page.svelte: 10 lines (received, made) Result: Reduced CSS warnings from 85 to 46 (eliminated all badge-related warnings) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove unused .header CSS from accounts, payments pages - Remove unused .header .btn and .header button from reports page - Remove empty .declarations ruleset from tax page - Fix chartCanvas/cashFlowCanvas to use $state for Svelte 5 compatibility Reduces warnings from 46 to 39 (7 more warnings eliminated) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add for/id associations to form labels in banking pages - Add aria-label to close buttons in cost-centers modals and alerts - Change group labels (line items, logo) from <label> to <span> since they don't associate with single form controls Reduces warnings from 39 to 14 (25 a11y warnings fixed) Remaining 14 warnings are mostly OnboardingWizard's intentional form initialization pattern (capturing prop values on mount). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add tabindex="-1" to dialog elements for focus management - Add keyboard handlers for Escape key on modal overlays - Add svelte-ignore comments for intentional non-interactive interactions Reduces warnings from 14 to 10 (all remaining are OnboardingWizard's intentional form initialization pattern) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive cleanup of unused CSS, Svelte 5 warnings, and accessibility issues. This PR significantly improves code quality and reduces warnings from 85 to 10 (88% reduction).
CSS Cleanup After StatusBadge Migration (255 lines removed)
Badge CSS cleanup (13 files):
Additional CSS cleanup (5 files):
.headerCSS from accounts, payments, reports pages.declarationsruleset from tax pageSvelte 5 Fixes
chartCanvas/cashFlowCanvasto use$statefor proper reactivity in dashboardAccessibility Improvements (9 files)
for/idassociations to form labels in banking pagesaria-labelto close buttons in cost-centers modals and alerts<label>to<span>tabindex="-1"to dialog elements for focus managementResults
Remaining 10 warnings are OnboardingWizard's intentional form initialization pattern (capturing prop values on mount for edit forms)
Files Changed: 28 total
Test plan
npm run checkpasses (0 errors, 10 warnings)🤖 Generated with Claude Code