Separate Metal 3 driver in the device enumerator #1835
Conversation
colincornaby
force-pushed
the
Metal-3-as-discrete-API-type
branch
from
72d2706 to
5123ad2
Compare
| devSel.RemoveUnusableDevModes(true); | ||
|
|
||
| if (!devSel.GetDefault(&dmr)) | ||
| if (!devSel.GetRequested(&dmr, devmode)) |
There was a problem hiding this comment.
@dpogue - Detecting audio/video settings was using default device instead of the requested device. Not sure if that's intentional. I might at least need to add a backup case of checking the default device for display modes?
There was a problem hiding this comment.
@dpogue - Just checking in on this question again in since you had another comment on this PR.
There was a problem hiding this comment.
Passing devmode as a bool here is definitely not right (since the second argument to GetRequested is a DeviceType enum value).
I think it is expected/correct that this case uses the default device, since this is the fallback if the requested device can't be in plClient::InitPipeline.
FYI this code was slightly modified in #1744 to enumerate based on the default display handle.
There was a problem hiding this comment.
Oh jees, why did the compiler let me get away with that?
But I'm also not sure if should be the default device when the user specifies a renderer as an argument.
I'll look at the other PR.
There was a problem hiding this comment.
Ok, I've reverted this change. I wanted to fix it, but this is all run too early, so maybe some other time...
It's not technically a huge problem. As long as all the renderers agree on possible display modes.
colincornaby
force-pushed
the
Metal-3-as-discrete-API-type
branch
from
aa764f5 to
f5dea00
Compare
3 participants
This is a commit that adds the Metal 3 check directly into the device enumerator. This allows a user or developer to ask specifically for the Metal 2 renderer on a Metal 3 system.
Not hooked up to anything yet - but needs to be hooked up to the Argument Buffer PR which has Metal 2/3 specific behaviors. This is being done as a direct result of a Metal 2 bug getting past testing because all my dev systems have Metal 3 GPUs.