Release

[GyeongHoKim]

User description

Resolves #8, #32, #36

---

PR Type

Bug fix, Enhancement, Tests

---

Description

• Fix ShadowDOM issue with Kakao APIs

• Add kakao-map component with extensive properties

• Add map context for component communication

• Implement semantic-release CI workflow

---

Changes walkthrough 📝

	Relevant files
Enhancement	10 files map.ts Add main kakao-map web component                                                  +444/-0  errors.ts Add error types for Kakao map components                                  +77/-0    guards.ts Add type guards for LatLng and Point types                              +21/-0    map-context.ts Add map context for component communication                            +4/-0      latlng.d.ts Add LatLng type definition                                                              +8/-0      point.d.ts Add Point type definition                                                                +8/-0      index.ts Export map component in package index                                        +1/-0      index.ts Add index file for map component exports                                  +1/-0      index.ts Add index file for context exports                                              +1/-0      component-index.html Update component test HTML with proper styling                      +13/-1
Tests	2 files map.component.ts Add tests for kakao-map component                                                +291/-0  api-loader.component.ts Update tests for api-loader without shadowDOM                        +16/-14
Bug fix	1 files api-loader.ts Remove shadow DOM to fix Kakao API issue                                  +13/-12
Configuration changes	2 files release.config.js Add semantic-release configuration                                              +46/-0    release.yaml Update GitHub workflow to use semantic-release                      +13/-48
Dependencies	2 files package.json Add dependencies and update version for semantic-release  +10/-1    package.json Add npm-run-all dev dependency                                                      +1/-0
Additional files	3 files LICENSE +0/-21    LICENSE +0/-21    pnpm-lock.yaml +1997/-5

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ 32 - Fully compliant Compliant requirements: • Fix issue with Kakao Map inside kakao-api-loader component • Address issue where Kakao map can't render markers and polylines properly inside shadowRoot • Fix the problem where Kakao map uses document.querySelector to render elements 8 - Fully compliant Compliant requirements: • Create kakao-map component 36 - Fully compliant Compliant requirements: • Apply semantic-release CI workflow • Automate version management and npm releasing • Focus on commit messages rather than debugging versions

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Error Exposure The error property is converted and reflected to attributes which might expose error details in the DOM. Consider if error details should be externally visible. @property({ type: Object, reflect: true, converter: { toAttribute: (value: ErrorEvent | undefined) => value ? '' : null, fromAttribute: (value: string | null) => value !== null ? new ErrorEvent('error') : undefined } }) error: ErrorEvent | undefined; Error Handling In the connectedCallback method, there's nested error handling that might lead to confusing behavior. The outer catch might swallow important errors from the inner catch block. try { super.connectedCallback(); this._container = document.createElement('div'); this._container.id = `${SIGNATURE}_Map_Container`; this._container.style.width = '100%'; this._container.style.height = '100%'; this.appendChild(this._container); if (window.kakao && window.kakao.maps) { this._initializeMap(); } else { const apiLoader = this.closest('kakao-api-loader'); if (apiLoader) { apiLoader.addEventListener('kakao-api-loaded', () => { try { if (window.kakao && window.kakao.maps) { this._initializeMap(); } } catch (error) { this._handleError(error instanceof Error ? new KakaoMapError(error.message) : new KakaoMapError('Unknown error occurred')); } }, { once: true }); } else { throw new KakaoMapAPIError(); } } } catch (error) { this._handleError(error instanceof KakaoMapError ? error : new KakaoMapError('Unknown error occurred')); } Resource Cleanup The disconnectedCallback doesn't fully clean up all resources. Event listeners might not be properly removed if the _map is undefined but was previously set. disconnectedCallback() { super.disconnectedCallback(); this._removeEventListeners(); if (this._loadCallback) { Loader.removeLoadEventLisnter(this._loadCallback); this._loadCallback = null; } if (this._container) { this._container.innerHTML = ''; if (this._container.parentNode === this) { this.removeChild(this._container); } this._container = null; } this._map = undefined;

[github-actions]

PR Code Suggestions ✨